[GCM] Add more UMA to GCM

google_apis/gcm/engine/unregistration_request.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "google_apis/gcm/engine/unregistration_request.h"
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 109 matching lines @@
       request_info_(request_info),
       registration_url_(registration_url),
       backoff_entry_(&backoff_policy),
       request_context_getter_(request_context_getter),
       recorder_(recorder),
       weak_ptr_factory_(this) {
 }
 
 UnregistrationRequest::~UnregistrationRequest() {}
 
 void UnregistrationRequest::Start() {

[fgorski, 2014/05/08 18:08:36]

Add UMA about Unregistration attempt.

[jianli, 2014/05/08 18:40:07]

What do you mean?

[fgorski, 2014/05/08 18:46:30]

My mistake, I was going for being symmetric with Registration request, but you
are logging the number of senders there, so my comment does not make sense.

   DCHECK(!callback_.is_null());
   DCHECK(request_info_.android_id != 0UL);
   DCHECK(request_info_.security_token != 0UL);
   DCHECK(!url_fetcher_.get());
 
   url_fetcher_.reset(net::URLFetcher::Create(
       registration_url_, net::URLFetcher::POST, this));
   url_fetcher_->SetRequestContext(request_context_getter_);
 
   std::string android_id = base::Uint64ToString(request_info_.android_id);
@@ skipping 11 matching lines @@
   BuildFormEncoding(kDeleteKey, kDeleteValue, &body);
   BuildFormEncoding(kUnregistrationCallerKey,
                     kUnregistrationCallerValue,
                     &body);
 
   DVLOG(1) << "Unregistration request: " << body;
   url_fetcher_->SetUploadData(kRequestContentType, body);
 
   DVLOG(1) << "Performing unregistration for: " << request_info_.app_id;
   recorder_->RecordUnregistrationSent(request_info_.app_id);
+  request_start_time_ = base::TimeTicks::Now();
   url_fetcher_->Start();
 }
 
 void UnregistrationRequest::RetryWithBackoff(bool update_backoff) {
   if (update_backoff) {
     url_fetcher_.reset();
     backoff_entry_.InformOfRequest(false);
   }
 
   if (backoff_entry_.ShouldRejectRequest()) {
@@ skipping 25 matching lines @@
                             status,
                             UNREGISTRATION_STATUS_COUNT);
   recorder_->RecordUnregistrationResponse(request_info_.app_id, status);
 
   if (status == URL_FETCHING_FAILED ||
       status == SERVICE_UNAVAILABLE ||
       status == INTERNAL_SERVER_ERROR ||
       status == INCORRECT_APP_ID ||
       status == RESPONSE_PARSING_FAILED) {
     RetryWithBackoff(true);
-  } else {
-    // status == SUCCESS || HTTP_NOT_OK || NO_RESPONSE_BODY ||
-    // INVALID_PARAMETERS || UNKNOWN_ERROR
-    callback_.Run(status);
+    return;
   }
+
+  // status == SUCCESS || HTTP_NOT_OK || NO_RESPONSE_BODY ||
+  // INVALID_PARAMETERS || UNKNOWN_ERROR
+
+  if (status == SUCCESS) {
+    UMA_HISTOGRAM_COUNTS("GCM.UnregistrationRetryNumber",

[fgorski, 2014/05/08 18:08:36]

Same comments as in Registration

[jianli, 2014/05/08 18:40:07]

ditto.

+                         backoff_entry_.failure_count() + 1);
+    UMA_HISTOGRAM_TIMES("GCM.UnregistrationCompleteTime",
+                        base::TimeTicks::Now() - request_start_time_);
+  }
+
+  callback_.Run(status);
 }
 
 }  // namespace gcm