Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2707793002: Revert of Detect H264 slices of the same frame in VEAUnittest (Closed)

Created:
3 years, 10 months ago by kcwu
Modified:
3 years, 10 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Detect H264 slices of the same frame in VEAUnittest (patchset #6 id:140001 of https://codereview.chromium.org/2538883002/ ) Reason for revert: This CL breaks many CTS/GTS tests. crbug.com/694094 Original issue's description: > Detect H264 slices of the same frame in VEAUnittest > > This CL adds checks similar to H264Decoder::IsNewPrimaryCodedPicture() to > determine if the given H264 slice belongs to a new frame. On Mac and Win, > we can have multiple slices per frame and this causes problems. > > Note that after this fix, I will add this test to chromium.gpu.fyi Mac bots. > Windows will follow when bots get upgraded to Win 8.1. > > BUG=669678 > TEST=Tested VEAUnittest on Macbook Air 2013. > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2538883002 > Cr-Commit-Position: refs/heads/master@{#451086} > Committed: https://chromium.googlesource.com/chromium/src/+/e80ab729b5fbe7b6ee7cf44551b0412a2e03f51f TBR=posciak@chromium.org,wuchengli@chromium.org,emircan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=694094 Review-Url: https://codereview.chromium.org/2707793002 Cr-Commit-Position: refs/heads/master@{#451575} Committed: https://chromium.googlesource.com/chromium/src/+/43364fb75871b5f530f4a63d8f78fe7a3134efbb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -168 lines) Patch
M media/gpu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/gpu/h264_decoder.h View 2 chunks +3 lines, -12 lines 0 comments Download
M media/gpu/h264_decoder.cc View 3 chunks +91 lines, -101 lines 0 comments Download
M media/gpu/video_encode_accelerator_unittest.cc View 5 chunks +3 lines, -54 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
kcwu
Created Revert of Detect H264 slices of the same frame in VEAUnittest
3 years, 10 months ago (2017-02-20 02:51:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707793002/1
3 years, 10 months ago (2017-02-20 02:51:18 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/393485)
3 years, 10 months ago (2017-02-20 05:37:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707793002/1
3 years, 10 months ago (2017-02-20 05:52:51 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 07:23:56 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/43364fb75871b5f530f4a63d8f78...

Powered by Google App Engine
This is Rietveld 408576698