Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2707743002: Use std::unique_ptr instead of linked_ptr in //components/guest_view (Closed)

Created:
3 years, 10 months ago by ke.he
Modified:
3 years, 10 months ago
Reviewers:
lazyboy
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use std::unique_ptr instead of linked_ptr in //components/guest_view BUG=556939 Review-Url: https://codereview.chromium.org/2707743002 Cr-Commit-Position: refs/heads/master@{#452006} Committed: https://chromium.googlesource.com/chromium/src/+/861e1e50380132d7028812bba3f3d4f073fa4c26

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M components/guest_view/browser/test_guest_view_manager.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/guest_view/browser/test_guest_view_manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
ke.he
lazyboy@, Could you PTAL on this? Thanks!
3 years, 10 months ago (2017-02-19 07:47:21 UTC) #6
lazyboy
lgtm!
3 years, 10 months ago (2017-02-21 21:44:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707743002/1
3 years, 10 months ago (2017-02-22 01:51:29 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-22 03:54:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707743002/1
3 years, 10 months ago (2017-02-22 11:18:05 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 12:10:19 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/861e1e50380132d7028812bba3f3...

Powered by Google App Engine
This is Rietveld 408576698