Issue 2707643002: Temporarily suppress element id collision DCHECK for SPV2

Issue 2707643002: Temporarily suppress element id collision DCHECK for SPV2 (Closed)

Created:
3 years, 10 months ago by pdr.

Modified:
3 years, 10 months ago

Reviewers:
chrishtr, ajuma

CC:
cc-bugs_chromium.org, chromium-reviews

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Temporarily suppress element id collision DCHECK for SPV2 This patch temporarily suppresses an id collision DCHECK with SPV2 which is failing because multiple layers have the same element id. This occurs for simple cases [1] because many unnecessary layers are created with the same property tree state. We explored fixing this with [2] but decided the long-term fix described in crbug.com/693693 would be better. This suppression should be removed once crbug.com/693693 is fixed. [1] Enable SPV2 with --enable-slimming-paint-v2, then open: <!doctype html> abc<div style="width: 10px; height: 5000px; transform: translate3d(0,0,0);">def</div> [2] https://codereview.chromium.org/2698673007 BUG=667946, 693693 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2707643002 Cr-Commit-Position: refs/heads/master@{#451797} Committed: https://chromium.googlesource.com/chromium/src/+/ff33efd971d548425b385adc947f8618788eb666

Patch Set 1 #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	cc/trees/layer_tree_impl.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 10 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

pdr.

Description was changed from ========== Temporarily suppress element id collision DCHECK for SPV2 This patch ...

3 years, 10 months ago (2017-02-18 04:33:13 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707643002/1

3 years, 10 months ago (2017-02-21 16:04:25 UTC) #7

commit-bot: I haz the power

Description was changed from ========== Temporarily suppress element id collision DCHECK for SPV2 This patch ...

3 years, 10 months ago (2017-02-21 18:14:04 UTC) #9

Message was sent while issue was closed.

Description was changed from

==========
Temporarily suppress element id collision DCHECK for SPV2

This patch temporarily suppresses an id collision DCHECK with SPV2 which
is failing because multiple layers have the same element id. This occurs for
simple cases [1] because many unnecessary layers are created with the
same property tree state. We explored fixing this with [2] but decided the
long-term fix described in crbug.com/693693 would be better.

This suppression should be removed once crbug.com/693693 is fixed.

[1] Enable SPV2 with --enable-slimming-paint-v2, then open:
<!doctype html>
abc<div style="width: 10px; height: 5000px; transform:
translate3d(0,0,0);">def</div>

[2] https://codereview.chromium.org/2698673007

BUG=667946, 693693
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Temporarily suppress element id collision DCHECK for SPV2

This patch temporarily suppresses an id collision DCHECK with SPV2 which
is failing because multiple layers have the same element id. This occurs for
simple cases [1] because many unnecessary layers are created with the
same property tree state. We explored fixing this with [2] but decided the
long-term fix described in crbug.com/693693 would be better.

This suppression should be removed once crbug.com/693693 is fixed.

[1] Enable SPV2 with --enable-slimming-paint-v2, then open:
<!doctype html>
abc<div style="width: 10px; height: 5000px; transform:
translate3d(0,0,0);">def</div>

[2] https://codereview.chromium.org/2698673007

BUG=667946, 693693
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2707643002
Cr-Commit-Position: refs/heads/master@{#451797}
Committed:
https://chromium.googlesource.com/chromium/src/+/ff33efd971d548425b385adc947f...
==========

commit-bot: I haz the power

3 years, 10 months ago (2017-02-21 18:14:05 UTC) #10

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ff33efd971d548425b385adc947f...

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages