Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2707633002:
NQE: Cleanup the calls to the observation buffer (Closed)
DescriptionNQE: Cleanup the calls to the observation buffer
In Network Quality Estimator (NQE), cleanup the calls to the
observation buffer, and reduce duplication. This CL makes it simpler to
record accuracy of different statistics (see the linked bug).
BUG=649887
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
Review-Url: https://codereview.chromium.org/2707633002
Cr-Commit-Position: refs/heads/master@{#451854}
Committed: https://chromium.googlesource.com/chromium/src/+/b17f5a4f08fcccd4b4787e3c9d2e683183f5d7b3
Patch Set 1 : ps #
Messages
Total messages: 34 (27 generated)
Description was changed from ========== w w w w BUG= ========== to ========== Add boiler plate for recording prediction accuracy of different statistics BUG=649887 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Patchset #1 (id:60001) has been deleted
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add boiler plate for recording prediction accuracy of different statistics BUG=649887 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ========== to ========== Add boiler plate for recording prediction accuracy of different statistics Also clean up the related code for disallowed observation sources. BUG=649887 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #1 (id:60002) has been deleted
Patchset #1 (id:90001) has been deleted
Description was changed from ========== Add boiler plate for recording prediction accuracy of different statistics Also clean up the related code for disallowed observation sources. BUG=649887 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ========== to ========== NQE: Cleanup the calls to the observation buffer In Network Quality Estimator (NQE), cleanup the calls to the observation buffer, and reduce duplication. This CL makes it simpler to record accuracy of different statistics (see the linked bug). BUG=649887 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ==========
tbansal@chromium.org changed reviewers: + ryansturm@chromium.org
ryansturm: ptal. Thanks.
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks. This has confused me a few times, thanks for the change.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by tbansal@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by tbansal@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 110001, "attempt_start_ts": 1487713891571490,
"parent_rev": "b57016555f22c0e162f449567d58e9a3a00b146f", "commit_rev":
"b17f5a4f08fcccd4b4787e3c9d2e683183f5d7b3"}
Message was sent while issue was closed.
Description was changed from ========== NQE: Cleanup the calls to the observation buffer In Network Quality Estimator (NQE), cleanup the calls to the observation buffer, and reduce duplication. This CL makes it simpler to record accuracy of different statistics (see the linked bug). BUG=649887 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ========== to ========== NQE: Cleanup the calls to the observation buffer In Network Quality Estimator (NQE), cleanup the calls to the observation buffer, and reduce duplication. This CL makes it simpler to record accuracy of different statistics (see the linked bug). BUG=649887 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2707633002 Cr-Commit-Position: refs/heads/master@{#451854} Committed: https://chromium.googlesource.com/chromium/src/+/b17f5a4f08fcccd4b4787e3c9d2e... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:110001) as https://chromium.googlesource.com/chromium/src/+/b17f5a4f08fcccd4b4787e3c9d2e... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
