src/runtime.cc - Issue 270763003: Object.observe: avoid accessing acceptList properties more than once

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 270763003: Object.observe: avoid accessing acceptList properties more than once (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index 743b34b534639a31917e1097ee27558605696b25..4bf63476228feb89c7bead7f9c7bc68fc1c886de 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -14999,7 +14999,6 @@ RUNTIME_FUNCTION(Runtime_ObjectObserveInObjectContext) {

CONVERT_ARG_HANDLE_CHECKED(JSObject, object, 0);

CONVERT_ARG_HANDLE_CHECKED(JSFunction, callback, 1);

CONVERT_ARG_HANDLE_CHECKED(Object, accept, 2);

- RUNTIME_ASSERT(accept->IsUndefined() || accept->IsJSObject());

Handle<Context> context(object->GetCreationContext(), isolate);

Handle<JSFunction> function(context->native_object_observe(), isolate);

« no previous file with comments | « src/object-observe.js ('k') | test/mjsunit/regress/regress-3315.js » ('j') | no next file with comments »