Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: src/runtime.cc

Issue 270763003: Object.observe: avoid accessing acceptList properties more than once (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/object-observe.js ('k') | test/mjsunit/regress/regress-3315.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdlib.h> 5 #include <stdlib.h>
6 #include <limits> 6 #include <limits>
7 7
8 #include "v8.h" 8 #include "v8.h"
9 9
10 #include "accessors.h" 10 #include "accessors.h"
(...skipping 14981 matching lines...) Expand 10 before | Expand all | Expand 10 after
14992 ContextsHaveSameOrigin(creation_context, isolate->native_context())); 14992 ContextsHaveSameOrigin(creation_context, isolate->native_context()));
14993 } 14993 }
14994 14994
14995 14995
14996 RUNTIME_FUNCTION(Runtime_ObjectObserveInObjectContext) { 14996 RUNTIME_FUNCTION(Runtime_ObjectObserveInObjectContext) {
14997 HandleScope scope(isolate); 14997 HandleScope scope(isolate);
14998 ASSERT(args.length() == 3); 14998 ASSERT(args.length() == 3);
14999 CONVERT_ARG_HANDLE_CHECKED(JSObject, object, 0); 14999 CONVERT_ARG_HANDLE_CHECKED(JSObject, object, 0);
15000 CONVERT_ARG_HANDLE_CHECKED(JSFunction, callback, 1); 15000 CONVERT_ARG_HANDLE_CHECKED(JSFunction, callback, 1);
15001 CONVERT_ARG_HANDLE_CHECKED(Object, accept, 2); 15001 CONVERT_ARG_HANDLE_CHECKED(Object, accept, 2);
15002 RUNTIME_ASSERT(accept->IsUndefined() || accept->IsJSObject());
15003 15002
15004 Handle<Context> context(object->GetCreationContext(), isolate); 15003 Handle<Context> context(object->GetCreationContext(), isolate);
15005 Handle<JSFunction> function(context->native_object_observe(), isolate); 15004 Handle<JSFunction> function(context->native_object_observe(), isolate);
15006 Handle<Object> call_args[] = { object, callback, accept }; 15005 Handle<Object> call_args[] = { object, callback, accept };
15007 Handle<Object> result; 15006 Handle<Object> result;
15008 15007
15009 ASSIGN_RETURN_FAILURE_ON_EXCEPTION( 15008 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
15010 isolate, result, 15009 isolate, result,
15011 Execution::Call(isolate, function, 15010 Execution::Call(isolate, function,
15012 handle(context->object_function(), isolate), 15011 handle(context->object_function(), isolate),
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
15263 } 15262 }
15264 return NULL; 15263 return NULL;
15265 } 15264 }
15266 15265
15267 15266
15268 const Runtime::Function* Runtime::FunctionForId(Runtime::FunctionId id) { 15267 const Runtime::Function* Runtime::FunctionForId(Runtime::FunctionId id) {
15269 return &(kIntrinsicFunctions[static_cast<int>(id)]); 15268 return &(kIntrinsicFunctions[static_cast<int>(id)]);
15270 } 15269 }
15271 15270
15272 } } // namespace v8::internal 15271 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/object-observe.js ('k') | test/mjsunit/regress/regress-3315.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698