Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2707583002: Revert of Resume the main job immediately when QUIC job fails, not wait for the head start timer to exprie (Closed)

Created:
3 years, 10 months ago by Zhongyi Shi
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Revert of Resume the main job immediately when QUIC job fails, not wait for the head start timer to exprie (patchset #1 id:1 of https://codereview.chromium.org/2701913003/ ) Reason for revert: Unittests has dependency on cls which is not merged. Original issue's description: > Resume the main job immediately when QUIC job fails, not wait for the head start timer to exprie > > BUG=691688 > > Review-Url: https://codereview.chromium.org/2693043008 > Cr-Commit-Position: refs/heads/master@{#450705} > (cherry picked from commit ff2bfbfd76f3c43e5618addd34c82fed42d2a6f5) > > Review-Url: https://codereview.chromium.org/2701913003 . > Cr-Commit-Position: refs/branch-heads/2987@{#583} > Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} > Committed: https://chromium.googlesource.com/chromium/src/+/71fe65787c774c74c90c397ac90293c75aad6a5f TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=691688 Review-Url: https://codereview.chromium.org/2707583002 Cr-Commit-Position: refs/branch-heads/2987@{#584} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/75d8442e1d3f6d4358da176aa0092c03c76b975d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -96 lines) Patch
M net/http/http_stream_factory_impl_job_controller.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller.cc View 3 chunks +3 lines, -17 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller_unittest.cc View 1 chunk +3 lines, -72 lines 0 comments Download
M net/http/http_stream_factory_test_util.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
Zhongyi Shi
3 years, 10 months ago (2017-02-17 23:48:25 UTC) #2
Created Revert of Resume the main job immediately when QUIC job fails, not wait
for the head start timer to exprie

Powered by Google App Engine
This is Rietveld 408576698