Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2707483002: Mojo C++ bindings: change some std::unique_ptr<base::Lock> to base::Optional<base::Lock>. (Closed)

Created:
3 years, 10 months ago by yzshen1
Modified:
3 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: change some std::unique_ptr<base::Lock> to base::Optional<base::Lock>. This helps to reduce heap allocation. BUG=651103, 693476 Review-Url: https://codereview.chromium.org/2707483002 Cr-Commit-Position: refs/heads/master@{#451394} Committed: https://chromium.googlesource.com/chromium/src/+/9ac6e6466cc0df7e1a3ad4488c5c8bdc2db4da36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -46 lines) Patch
M mojo/public/cpp/bindings/connector.h View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/connector.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/lib/may_auto_lock.h View 3 chunks +5 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/multiplex_router.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/multiplex_router.cc View 24 chunks +25 lines, -23 lines 0 comments Download
M mojo/public/cpp/bindings/lib/scoped_interface_endpoint_handle.cc View 10 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
3 years, 10 months ago (2017-02-17 19:14:58 UTC) #3
Ken Rockot(use gerrit already)
lgtm
3 years, 10 months ago (2017-02-17 19:16:13 UTC) #5
yzshen1
On 2017/02/17 19:16:13, Ken Rockot wrote: > lgtm I wonder how fast you can do ...
3 years, 10 months ago (2017-02-17 19:16:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707483002/1
3 years, 10 months ago (2017-02-17 19:17:24 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 23:08:40 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9ac6e6466cc0df7e1a3ad4488c5c...

Powered by Google App Engine
This is Rietveld 408576698