[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your
OWNERS files. Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
Review-Url: https://codereview.chromium.org/2707433004
Cr-Commit-Position: refs/heads/master@{#451880}
Committed: https://chromium.googlesource.com/chromium/src/+/6d2d654291ab0740e2bb3d28c4025dc1405767fb

[ymzhang1, 2017-02-18 01:16:17]

ymzhang@chromium.org changed reviewers:
+ mark@chromium.org

[ymzhang1, 2017-02-18 01:16:17]

Hello,

We are adding COMPONENT/TEAM information into OWNERS file. Would you mind
helping us to verify the added TEAM/COMPONENT or suggest the correct
TEAM/COMPONENT in your OWNERS files? Thank you very much!

[ymzhang1, 2017-02-18 01:25:18]

In addition,

For the following OWNERS files you owned, may I know if any of them could add a
component?

third_party/sudden_motion_sensor,
third_party/mozilla,
third_party/google_toolbox_for_mac,
third_party/apple_apsl,
third_party/mach_override,
chrome/common/mac,

Thanks!

[Mark Mentovai, 2017-02-18 03:42:57]

Is it OK for a TEAM to name a Google-internal list? Probably not, right?

https://codereview.chromium.org/2707433004/diff/1/breakpad/OWNERS
File breakpad/OWNERS (right):

https://codereview.chromium.org/2707433004/diff/1/breakpad/OWNERS#newcode8
breakpad/OWNERS:8: # TEAM: layout-dev@chromium.org
TEAM: google-breakpad-dev@googlegroups.com

https://codereview.chromium.org/2707433004/diff/1/build/secondary/third_party...
File build/secondary/third_party/crashpad/OWNERS (right):

https://codereview.chromium.org/2707433004/diff/1/build/secondary/third_party...
build/secondary/third_party/crashpad/OWNERS:5: # COMPONENT:
Internals>CrashReporting
TEAM: crashpad-dev@chromium.org

https://codereview.chromium.org/2707433004/diff/1/chrome/browser/obsolete_sys...
File chrome/browser/obsolete_system/OWNERS (right):

https://codereview.chromium.org/2707433004/diff/1/chrome/browser/obsolete_sys...
chrome/browser/obsolete_system/OWNERS:9: # COMPONENT:
UI>Browser>Mobile>TapToSearch
Nope.

https://codereview.chromium.org/2707433004/diff/1/services/device/time_zone_m...
File services/device/time_zone_monitor/OWNERS (right):

https://codereview.chromium.org/2707433004/diff/1/services/device/time_zone_m...
services/device/time_zone_monitor/OWNERS:4: # COMPONENT: Services>SupervisedUser
Nope.

https://codereview.chromium.org/2707433004/diff/1/third_party/crashpad/OWNERS
File third_party/crashpad/OWNERS (right):

https://codereview.chromium.org/2707433004/diff/1/third_party/crashpad/OWNERS...
third_party/crashpad/OWNERS:17: # COMPONENT: Internals>CrashReporting
TEAM: crashpad-dev@chromium.org

[ymzhang1, 2017-02-21 18:13:03]

Thank you very much for the comments!

For now, we think it's better to provide only public mailing list in OWNERS
files.

One question about crashpad-dev@chromium.org for Internals>CrashReporting.
Will crashpad-dev@ be the primary team to triage bugs related to
Internals>CrashReporting? If no, we might need to replace with a more specific
component. We could keep team information and add component later if currently
there's no proper component.

https://codereview.chromium.org/2707433004/diff/1/breakpad/OWNERS
File breakpad/OWNERS (right):

https://codereview.chromium.org/2707433004/diff/1/breakpad/OWNERS#newcode8
breakpad/OWNERS:8: # TEAM: layout-dev@chromium.org
On 2017/02/18 03:42:56, Mark Mentovai wrote:
> TEAM: mailto:google-breakpad-dev@googlegroups.com

For current plan, we think it might be better only add public mailing list in
OWENRS file. I'll keep record this team information on the my mapping list. 

Meanwhile, we would like to have at most one team mailing list for each
component. Would you mind keeping this team (as it corresponding to
Internals>Core) or suggesting another more specific component for this
directory? Thanks!

https://codereview.chromium.org/2707433004/diff/1/build/secondary/third_party...
File build/secondary/third_party/crashpad/OWNERS (right):

https://codereview.chromium.org/2707433004/diff/1/build/secondary/third_party...
build/secondary/third_party/crashpad/OWNERS:5: # COMPONENT:
Internals>CrashReporting
On 2017/02/18 03:42:56, Mark Mentovai wrote:
> TEAM: mailto:crashpad-dev@chromium.org

Done.

https://codereview.chromium.org/2707433004/diff/1/chrome/browser/obsolete_sys...
File chrome/browser/obsolete_system/OWNERS (right):

https://codereview.chromium.org/2707433004/diff/1/chrome/browser/obsolete_sys...
chrome/browser/obsolete_system/OWNERS:9: # COMPONENT:
UI>Browser>Mobile>TapToSearch
On 2017/02/18 03:42:56, Mark Mentovai wrote:
> Nope.

No proper component and remove this line?

https://codereview.chromium.org/2707433004/diff/1/services/device/time_zone_m...
File services/device/time_zone_monitor/OWNERS (right):

https://codereview.chromium.org/2707433004/diff/1/services/device/time_zone_m...
services/device/time_zone_monitor/OWNERS:4: # COMPONENT: Services>SupervisedUser
On 2017/02/18 03:42:56, Mark Mentovai wrote:
> Nope.

Remove this line?

https://codereview.chromium.org/2707433004/diff/1/third_party/crashpad/OWNERS
File third_party/crashpad/OWNERS (right):

https://codereview.chromium.org/2707433004/diff/1/third_party/crashpad/OWNERS...
third_party/crashpad/OWNERS:17: # COMPONENT: Internals>CrashReporting
On 2017/02/18 03:42:56, Mark Mentovai wrote:
> TEAM: mailto:crashpad-dev@chromium.org

Done.

[Mark Mentovai, 2017-02-21 20:24:18]

https://codereview.chromium.org/2707433004/diff/1/breakpad/OWNERS
File breakpad/OWNERS (right):

https://codereview.chromium.org/2707433004/diff/1/breakpad/OWNERS#newcode8
breakpad/OWNERS:8: # TEAM: layout-dev@chromium.org
On 2017/02/21 18:13:03, ymzhang1 wrote:
> On 2017/02/18 03:42:56, Mark Mentovai wrote:
> > TEAM: mailto:google-breakpad-dev@googlegroups.com
> 
> For current plan, we think it might be better only add public mailing list in
> OWENRS file. I'll keep record this team information on the my mapping list. 

google-breakpad-dev@googlegroups.com is a public list.

> Meanwhile, we would like to have at most one team mailing list for each
> component. Would you mind keeping this team (as it corresponding to
> Internals>Core) or suggesting another more specific component for this
> directory? Thanks!

Internals>Core isn’t specific enough. Internals>CrashReporting is better for
this directory.

https://codereview.chromium.org/2707433004/diff/1/chrome/browser/obsolete_sys...
File chrome/browser/obsolete_system/OWNERS (right):

https://codereview.chromium.org/2707433004/diff/1/chrome/browser/obsolete_sys...
chrome/browser/obsolete_system/OWNERS:9: # COMPONENT:
UI>Browser>Mobile>TapToSearch
ymzhang1 wrote:
> On 2017/02/18 03:42:56, Mark Mentovai wrote:
> > Nope.
> 
> No proper component and remove this line?

I’m not sure but I don’t think that there’s a proper component. It’s definitely
not this. Remove the line.

https://codereview.chromium.org/2707433004/diff/1/services/device/time_zone_m...
File services/device/time_zone_monitor/OWNERS (right):

https://codereview.chromium.org/2707433004/diff/1/services/device/time_zone_m...
services/device/time_zone_monitor/OWNERS:4: # COMPONENT: Services>SupervisedUser
ymzhang1 wrote:
> On 2017/02/18 03:42:56, Mark Mentovai wrote:
> > Nope.
> 
> Remove this line?

Yup, same thing.

https://codereview.chromium.org/2707433004/diff/1/third_party/crashpad/OWNERS
File third_party/crashpad/OWNERS (right):

https://codereview.chromium.org/2707433004/diff/1/third_party/crashpad/OWNERS...
third_party/crashpad/OWNERS:17: # COMPONENT: Internals>CrashReporting
On 2017/02/21 18:13:03, ymzhang1 wrote:
> One question about crashpad-dev@chromium.org for Internals>CrashReporting.
> Will crashpad-dev@ be the primary team to triage bugs related to
> Internals>CrashReporting?

No, it’s more specific than Internals>CrashReporting.

> If no, we might need to replace with a more specific
> component. We could keep team information and add component later if currently
> there's no proper component.

Crash-reporting bugs specific to Crashpad shouldn’t have a Chrome component,
they should be entered into Crashpad’s own issue tracker at
https://crashpad.chromium.org/bug (redirects to /p/crashpad).

[ymzhang1, 2017-02-21 21:00:51]

Patchset #2 (id:20001) has been deleted

[ymzhang1, 2017-02-21 21:08:18]

Patchset #2 (id:40001) has been deleted

[ymzhang1, 2017-02-21 21:10:07]

https://codereview.chromium.org/2707433004/diff/1/breakpad/OWNERS
File breakpad/OWNERS (right):

https://codereview.chromium.org/2707433004/diff/1/breakpad/OWNERS#newcode8
breakpad/OWNERS:8: # TEAM: layout-dev@chromium.org
On 2017/02/21 20:24:18, Mark Mentovai wrote:
> On 2017/02/21 18:13:03, ymzhang1 wrote:
> > On 2017/02/18 03:42:56, Mark Mentovai wrote:
> > > TEAM: mailto:google-breakpad-dev@googlegroups.com
> > 
> > For current plan, we think it might be better only add public mailing list
in
> > OWENRS file. I'll keep record this team information on the my mapping list. 
> 
> mailto:google-breakpad-dev@googlegroups.com is a public list.
> 
> > Meanwhile, we would like to have at most one team mailing list for each
> > component. Would you mind keeping this team (as it corresponding to
> > Internals>Core) or suggesting another more specific component for this
> > directory? Thanks!
> 
> Internals>Core isn’t specific enough. Internals>CrashReporting is better for
> this directory.

Done.

https://codereview.chromium.org/2707433004/diff/1/chrome/browser/obsolete_sys...
File chrome/browser/obsolete_system/OWNERS (right):

https://codereview.chromium.org/2707433004/diff/1/chrome/browser/obsolete_sys...
chrome/browser/obsolete_system/OWNERS:9: # COMPONENT:
UI>Browser>Mobile>TapToSearch
On 2017/02/21 20:24:18, Mark Mentovai wrote:
> ymzhang1 wrote:
> > On 2017/02/18 03:42:56, Mark Mentovai wrote:
> > > Nope.
> > 
> > No proper component and remove this line?
> 
> I’m not sure but I don’t think that there’s a proper component. It’s
definitely
> not this. Remove the line.

Done.

https://codereview.chromium.org/2707433004/diff/1/services/device/time_zone_m...
File services/device/time_zone_monitor/OWNERS (right):

https://codereview.chromium.org/2707433004/diff/1/services/device/time_zone_m...
services/device/time_zone_monitor/OWNERS:4: # COMPONENT: Services>SupervisedUser
On 2017/02/21 20:24:18, Mark Mentovai wrote:
> ymzhang1 wrote:
> > On 2017/02/18 03:42:56, Mark Mentovai wrote:
> > > Nope.
> > 
> > Remove this line?
> 
> Yup, same thing.

Done.

https://codereview.chromium.org/2707433004/diff/1/third_party/crashpad/OWNERS
File third_party/crashpad/OWNERS (right):

https://codereview.chromium.org/2707433004/diff/1/third_party/crashpad/OWNERS...
third_party/crashpad/OWNERS:17: # COMPONENT: Internals>CrashReporting
On 2017/02/21 20:24:18, Mark Mentovai wrote:
> On 2017/02/21 18:13:03, ymzhang1 wrote:
> > One question about mailto:crashpad-dev@chromium.org for
Internals>CrashReporting.
> > Will crashpad-dev@ be the primary team to triage bugs related to
> > Internals>CrashReporting?
> 
> No, it’s more specific than Internals>CrashReporting.
> 
> > If no, we might need to replace with a more specific
> > component. We could keep team information and add component later if
currently
> > there's no proper component.
> 
> Crash-reporting bugs specific to Crashpad shouldn’t have a Chrome component,
> they should be entered into Crashpad’s own issue tracker at
> https://crashpad.chromium.org/bug (redirects to /p/crashpad).

I see. I would only add TEAM information here.

[Mark Mentovai, 2017-02-21 21:53:09]

LGTM

[ymzhang1, 2017-02-21 21:58:28]

The CQ bit was checked by ymzhang@chromium.org

[commit-bot: I haz the power, 2017-02-21 21:59:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 00:05:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 00:05:44]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[ymzhang1, 2017-02-22 00:06:29]

The CQ bit was checked by ymzhang@chromium.org

[commit-bot: I haz the power, 2017-02-22 00:07:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 01:46:01]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487721989738410,
"parent_rev": "85373b87a986b488d5223e417505358eaf44eead", "commit_rev":
"6d2d654291ab0740e2bb3d28c4025dc1405767fb"}

[commit-bot: I haz the power, 2017-02-22 01:46:51]

Description was changed from

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your
OWNERS files. Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
==========

to

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your
OWNERS files. Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
Component lists
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905

Review-Url: https://codereview.chromium.org/2707433004
Cr-Commit-Position: refs/heads/master@{#451880}
Committed:
https://chromium.googlesource.com/chromium/src/+/6d2d654291ab0740e2bb3d28c402...
==========

[commit-bot: I haz the power, 2017-02-22 01:46:52]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6d2d654291ab0740e2bb3d28c402...