Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2707433003: Convert mixing.html test to testharness. (Closed)

Created:
3 years, 10 months ago by Raymond Toy
Modified:
3 years, 9 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert mixing.html test to testharness. Manually convert this test to testharness and new Audit. And since it's a large rewrite already, change the test so that we don't need an expected result file and compute the expected result ourselves. BUG=692795 TEST=mixing.html Review-Url: https://codereview.chromium.org/2707433003 Cr-Commit-Position: refs/heads/master@{#453313} Committed: https://chromium.googlesource.com/chromium/src/+/881138dbcad4dfa151638b8bba643d8d7b43374c

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -44 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/mixing.html View 1 1 chunk +111 lines, -44 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/mixing-expected.wav View Binary file 0 comments Download

Messages

Total messages: 10 (5 generated)
Raymond Toy
PTAL
3 years, 10 months ago (2017-02-22 23:14:30 UTC) #2
hongchan
lgtm with nits https://codereview.chromium.org/2707433003/diff/1/third_party/WebKit/LayoutTests/webaudio/mixing.html File third_party/WebKit/LayoutTests/webaudio/mixing.html (right): https://codereview.chromium.org/2707433003/diff/1/third_party/WebKit/LayoutTests/webaudio/mixing.html#newcode28 third_party/WebKit/LayoutTests/webaudio/mixing.html:28: // Load up audio files It ...
3 years, 9 months ago (2017-02-27 18:10:37 UTC) #3
Raymond Toy
https://codereview.chromium.org/2707433003/diff/1/third_party/WebKit/LayoutTests/webaudio/mixing.html File third_party/WebKit/LayoutTests/webaudio/mixing.html (right): https://codereview.chromium.org/2707433003/diff/1/third_party/WebKit/LayoutTests/webaudio/mixing.html#newcode28 third_party/WebKit/LayoutTests/webaudio/mixing.html:28: // Load up audio files On 2017/02/27 18:10:36, hongchan ...
3 years, 9 months ago (2017-02-27 19:02:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707433003/20001
3 years, 9 months ago (2017-02-27 19:03:41 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 20:11:11 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/881138dbcad4dfa151638b8bba64...

Powered by Google App Engine
This is Rietveld 408576698