Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2707433002: [heap] Remove Heap::TracePath* functions. (Closed)

Created:
3 years, 10 months ago by ulan
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove Heap::TracePath* functions. The functions do not work correctly with concurrent sweeper and they do not take weak references into account. The latter is a fundamental problem for this tracing approach. BUG= Review-Url: https://codereview.chromium.org/2707433002 Cr-Commit-Position: refs/heads/master@{#43284} Committed: https://chromium.googlesource.com/v8/v8/+/9e187ea91ba7e455ffd7cd584bb6426b0fa82ef4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -207 lines) Patch
M src/heap/heap.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -188 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
ulan
PTAL.
3 years, 10 months ago (2017-02-17 14:11:48 UTC) #2
Michael Lippautz
On 2017/02/17 14:11:48, ulan wrote: > PTAL. lgtm, although I found them rather useful for ...
3 years, 10 months ago (2017-02-17 14:13:45 UTC) #3
ulan
On 2017/02/17 14:13:45, Michael Lippautz wrote: > On 2017/02/17 14:11:48, ulan wrote: > > PTAL. ...
3 years, 10 months ago (2017-02-17 14:22:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707433002/1
3 years, 10 months ago (2017-02-17 14:22:41 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 15:07:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/9e187ea91ba7e455ffd7cd584bb6426b0fa...

Powered by Google App Engine
This is Rietveld 408576698