Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2707423002:
setup mb_config.pyl for linux_chromium_clobber_deterministic. (Closed)
|
Created:
3 years, 10 months ago by Yoshisato Yanagisawa Modified:
3 years, 10 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionsetup mb_config.pyl for Deterministic Linux.
BUG=
Review-Url: https://codereview.chromium.org/2707423002
Cr-Commit-Position: refs/heads/master@{#452689}
Committed: https://chromium.googlesource.com/chromium/src/+/1807f91fb1262cd7c29e766e507d852ef2af8867
Patch Set 1 #
Total comments: 6
Patch Set 2 : has Deterministic Linux #Patch Set 3 : remove linux chormium clobber deterministic #Messages
Total messages: 18 (8 generated)
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
https://codereview.chromium.org/2707423002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2707423002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:273: 'Linux Deterministic': 'release_bot', Should this be "Deterministic Linux" now? https://codereview.chromium.org/2707423002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:274: 'linux_chromium_clobber_deterministic': 'release_bot', I'm guessing this needs to be on tryserver.chromium.linux instead?
yyanagisawa@google.com changed reviewers: + yyanagisawa@google.com
https://codereview.chromium.org/2707423002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2707423002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:273: 'Linux Deterministic': 'release_bot', On 2017/02/23 02:52:46, Dirk Pranke wrote: > Should this be "Deterministic Linux" now? Done. https://codereview.chromium.org/2707423002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:274: 'linux_chromium_clobber_deterministic': 'release_bot', On 2017/02/23 02:52:46, Dirk Pranke wrote: > I'm guessing this needs to be on tryserver.chromium.linux instead? 'tryserver.chromium.linux' already has this.
https://codereview.chromium.org/2707423002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2707423002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:274: 'linux_chromium_clobber_deterministic': 'release_bot', On 2017/02/23 03:02:55, yyanagisawa wrote: > On 2017/02/23 02:52:46, Dirk Pranke wrote: > > I'm guessing this needs to be on tryserver.chromium.linux instead? > > 'tryserver.chromium.linux' already has this. Okay, well, you don't need this line. No such builder exists on the chromium.linux waterfall, right?
Description was changed from ========== setup mb_config.pyl for linux_chromium_clobber_deterministic. BUG= ========== to ========== setup mb_config.pyl for Deterministic Linux. BUG= ==========
https://codereview.chromium.org/2707423002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2707423002/diff/1/tools/mb/mb_config.pyl#newc... tools/mb/mb_config.pyl:274: 'linux_chromium_clobber_deterministic': 'release_bot', On 2017/02/23 03:07:34, Dirk Pranke wrote: > On 2017/02/23 03:02:55, yyanagisawa wrote: > > On 2017/02/23 02:52:46, Dirk Pranke wrote: > > > I'm guessing this needs to be on tryserver.chromium.linux instead? > > > > 'tryserver.chromium.linux' already has this. > > Okay, well, you don't need this line. No such builder exists on the > chromium.linux waterfall, right? Chiken -egg issue but when I land https://chromium-review.googlesource.com/c/444604/, yes.
On 2017/02/23 03:10:43, yyanagisawa wrote: > https://codereview.chromium.org/2707423002/diff/1/tools/mb/mb_config.pyl > File tools/mb/mb_config.pyl (right): > > https://codereview.chromium.org/2707423002/diff/1/tools/mb/mb_config.pyl#newc... > tools/mb/mb_config.pyl:274: 'linux_chromium_clobber_deterministic': > 'release_bot', > On 2017/02/23 03:07:34, Dirk Pranke wrote: > > On 2017/02/23 03:02:55, yyanagisawa wrote: > > > On 2017/02/23 02:52:46, Dirk Pranke wrote: > > > > I'm guessing this needs to be on tryserver.chromium.linux instead? > > > > > > 'tryserver.chromium.linux' already has this. > > > > Okay, well, you don't need this line. No such builder exists on the > > chromium.linux waterfall, right? > > Chiken -egg issue but when I land > https://chromium-review.googlesource.com/c/444604/, yes. Oh, I see. I missed that earlier. We definitely shouldn't use a name like that on chromium.linux, that would be even more confusing ...
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
Whoops :). LGTM.
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487891161770220,
"parent_rev": "9d3d9e158b990087e77b9b3fa9ae78a6c1c733b7", "commit_rev":
"1807f91fb1262cd7c29e766e507d852ef2af8867"}
Message was sent while issue was closed.
Description was changed from ========== setup mb_config.pyl for Deterministic Linux. BUG= ========== to ========== setup mb_config.pyl for Deterministic Linux. BUG= Review-Url: https://codereview.chromium.org/2707423002 Cr-Commit-Position: refs/heads/master@{#452689} Committed: https://chromium.googlesource.com/chromium/src/+/1807f91fb1262cd7c29e766e507d... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/1807f91fb1262cd7c29e766e507d... |
