Unify background color gutters.

Unify background color gutters.

There were 3 different mechanisms used for showing background color
around incorrectly sized content on the Android browser process:
A) setting CC root background color from StaticTabSceneLayer,
B) padding SolidColorLayers in tab_layer.cc for the phone tab switcher
C) a full-sized SolidColorLayer in DelegatedFrameHostAndroid.

In http://crrev.com/2566753004 I disrupted this and introduced some
over- and under-padding bugs (and I noticed a preexisting one).  This
patch fixes them by:
- Eliminating mechanism C, which is particularly redundant and
inefficient.
- Introducing a new method ContentLayer::ComputeSize() which is a way of
communicating with the TabLayer padding system that's more explicit than
the layer bounds setting that existed in the past.  It pulls in the
surface size information that mechanism C covered.
- Delegating the background color getter on the tablet
TabStripSceneLayer.  Mechanism B only had the correct color on phone,
not tablet, because the StaticTabSceneLayer is hidden one level deep.

Also do a bit of further cleanup of ContentLayer.

BUG=692490
Review-Url: https://codereview.chromium.org/2707403004
Cr-Commit-Position: refs/heads/master@{#453316}
Committed: https://chromium.googlesource.com/chromium/src/+/f0c242bac6c0a6cf422b637b6224da3d8ac5eb4c

[aelias_OOO_until_Jul13, 2017-02-24 04:44:16]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 04:44:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 05:25:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 05:25:01]

Dry run: This issue passed the CQ dry run.

[aelias_OOO_until_Jul13, 2017-02-24 05:34:14]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 05:34:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aelias_OOO_until_Jul13, 2017-02-24 05:37:05]

aelias@chromium.org changed reviewers:
+ boliu@chromium.org, changwan@chromium.org

[aelias_OOO_until_Jul13, 2017-02-24 05:37:27]

PTAL, 
changwan@ for chrome/browser/android/compositor/
boliu@ for deletion in ui/android/

[commit-bot: I haz the power, 2017-02-24 06:21:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 06:21:19]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[boliu, 2017-02-24 16:04:46]

content/ui lgtm for only removing code :)

[Changwan Ryu, 2017-02-27 14:28:37]

lgtm w/ nits

thanks for the refactoring!

https://codereview.chromium.org/2707403004/diff/20001/chrome/browser/android/...
File chrome/browser/android/compositor/layer/content_layer.cc (right):

https://codereview.chromium.org/2707403004/diff/20001/chrome/browser/android/...
chrome/browser/android/compositor/layer/content_layer.cc:36: static cc::Layer*
DrawContentsLeaf(scoped_refptr<cc::Layer> layer) {
nit: The name is a bit confusing to me because it sounds as if it has to draw
something.
How about renaming this to GetDrawsContentLeaf / GetContentDrawingLeaf /
DrawsContentLeaf?

[aelias_OOO_until_Jul13, 2017-02-27 19:33:46]

https://codereview.chromium.org/2707403004/diff/20001/chrome/browser/android/...
File chrome/browser/android/compositor/layer/content_layer.cc (right):

https://codereview.chromium.org/2707403004/diff/20001/chrome/browser/android/...
chrome/browser/android/compositor/layer/content_layer.cc:36: static cc::Layer*
DrawContentsLeaf(scoped_refptr<cc::Layer> layer) {
On 2017/02/27 at 14:28:37, Changwan Ryu wrote:
> nit: The name is a bit confusing to me because it sounds as if it has to draw
something.
> How about renaming this to GetDrawsContentLeaf / GetContentDrawingLeaf /
DrawsContentLeaf?

Done.

[aelias_OOO_until_Jul13, 2017-02-27 19:33:48]

The CQ bit was checked by aelias@chromium.org

[aelias_OOO_until_Jul13, 2017-02-27 19:33:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
changwan@chromium.org, boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2707403004/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-02-27 19:34:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 20:17:48]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488224028635960,
"parent_rev": "90129f52048e8042a9bb2caa618305da80ff6019", "commit_rev":
"f0c242bac6c0a6cf422b637b6224da3d8ac5eb4c"}

[commit-bot: I haz the power, 2017-02-27 20:18:53]

Description was changed from

==========
Unify background color gutters.

There were 3 different mechanisms used for showing background color
around incorrectly sized content on the Android browser process:
A) setting CC root background color from StaticTabSceneLayer,
B) padding SolidColorLayers in tab_layer.cc for the phone tab switcher
C) a full-sized SolidColorLayer in DelegatedFrameHostAndroid.

In http://crrev.com/2566753004 I disrupted this and introduced some
over- and under-padding bugs (and I noticed a preexisting one).  This
patch fixes them by:
- Eliminating mechanism C, which is particularly redundant and
inefficient.
- Introducing a new method ContentLayer::ComputeSize() which is a way of
communicating with the TabLayer padding system that's more explicit than
the layer bounds setting that existed in the past.  It pulls in the
surface size information that mechanism C covered.
- Delegating the background color getter on the tablet
TabStripSceneLayer.  Mechanism B only had the correct color on phone,
not tablet, because the StaticTabSceneLayer is hidden one level deep.

Also do a bit of further cleanup of ContentLayer.

BUG=692490
==========

to

==========
Unify background color gutters.

There were 3 different mechanisms used for showing background color
around incorrectly sized content on the Android browser process:
A) setting CC root background color from StaticTabSceneLayer,
B) padding SolidColorLayers in tab_layer.cc for the phone tab switcher
C) a full-sized SolidColorLayer in DelegatedFrameHostAndroid.

In http://crrev.com/2566753004 I disrupted this and introduced some
over- and under-padding bugs (and I noticed a preexisting one).  This
patch fixes them by:
- Eliminating mechanism C, which is particularly redundant and
inefficient.
- Introducing a new method ContentLayer::ComputeSize() which is a way of
communicating with the TabLayer padding system that's more explicit than
the layer bounds setting that existed in the past.  It pulls in the
surface size information that mechanism C covered.
- Delegating the background color getter on the tablet
TabStripSceneLayer.  Mechanism B only had the correct color on phone,
not tablet, because the StaticTabSceneLayer is hidden one level deep.

Also do a bit of further cleanup of ContentLayer.

BUG=692490

Review-Url: https://codereview.chromium.org/2707403004
Cr-Commit-Position: refs/heads/master@{#453316}
Committed:
https://chromium.googlesource.com/chromium/src/+/f0c242bac6c0a6cf422b637b6224...
==========

[commit-bot: I haz the power, 2017-02-27 20:18:54]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f0c242bac6c0a6cf422b637b6224...