Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2707383005: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 10 months ago
Reviewers:
lcwu1, halliwell, alokp
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, ozone-reviews_chromium.org, halliwell+watch_chromium.org, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: List of components https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=alokp@chromium.org Review-Url: https://codereview.chromium.org/2707383005 Cr-Commit-Position: refs/heads/master@{#452642} Committed: https://chromium.googlesource.com/chromium/src/+/4ac7a3cf3fcc807c7f90fba9442e304d2c92d3a6

Patch Set 1 #

Total comments: 2

Patch Set 2 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chromecast/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/ozone/platform/cast/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-23 20:57:33 UTC) #3
alokp
https://codereview.chromium.org/2707383005/diff/1/ui/ozone/platform/cast/OWNERS File ui/ozone/platform/cast/OWNERS (right): https://codereview.chromium.org/2707383005/diff/1/ui/ozone/platform/cast/OWNERS#newcode5 ui/ozone/platform/cast/OWNERS:5: # COMPONENT: Internals>Cast This should be Chromecast as well.
3 years, 10 months ago (2017-02-23 21:18:47 UTC) #4
ymzhang1
https://codereview.chromium.org/2707383005/diff/1/ui/ozone/platform/cast/OWNERS File ui/ozone/platform/cast/OWNERS (right): https://codereview.chromium.org/2707383005/diff/1/ui/ozone/platform/cast/OWNERS#newcode5 ui/ozone/platform/cast/OWNERS:5: # COMPONENT: Internals>Cast On 2017/02/23 21:18:47, alokp wrote: > ...
3 years, 10 months ago (2017-02-23 21:23:29 UTC) #5
alokp
Thanks! lgtm
3 years, 10 months ago (2017-02-23 21:32:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707383005/20001
3 years, 10 months ago (2017-02-23 21:34:10 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 21:44:44 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4ac7a3cf3fcc807c7f90fba9442e...

Powered by Google App Engine
This is Rietveld 408576698