Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(316)

Issue 2707383004: Remove redundant GetPermissionType call in ~ScopedRevocationReporter (Closed)

Created:
9 months, 3 weeks ago by Timothy Loh
Modified:
9 months, 3 weeks ago
Reviewers:
raymes
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, raymes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant GetPermissionType call in ~ScopedRevocationReporter The GetPermissionType call in ~ScopedRevocationReporter checks whether the given type has an associated PermissionType, but doesn't make use of the PermissionType value. The guarded function, PermissionRevoked, has a stricter check (notifications, geolocation, mic or camera), so there's no reason to actually call GetPermissionType. BUG=689799 Review-Url: https://codereview.chromium.org/2707383004 Cr-Commit-Position: refs/heads/master@{#452416} Committed: https://chromium.googlesource.com/chromium/src/+/a5284b9c11fb616ff61bc3343584409cf1e558fa

Patch Set 1 #

Messages

Total messages: 12 (8 generated)
Timothy Loh
A tiny clean-up :)
9 months, 3 weeks ago (2017-02-23 04:59:16 UTC) #4
raymes
lgtm
9 months, 3 weeks ago (2017-02-23 06:01:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707383004/1
9 months, 3 weeks ago (2017-02-23 06:02:53 UTC) #9
commit-bot: I haz the power
9 months, 3 weeks ago (2017-02-23 06:14:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a5284b9c11fb616ff61bc3343584...

Powered by Google App Engine
This is Rietveld 0eb02b776