Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2707383002: MD Settings: change confirm text to save startup url's dialog. (Closed)

Created:
3 years, 10 months ago by scottchen
Modified:
3 years, 10 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: change confirm text to save startup url's dialog. BUG=689093 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2707383002 Cr-Commit-Position: refs/heads/master@{#452304} Committed: https://chromium.googlesource.com/chromium/src/+/3bf98d03dbef1c18a79d3d86cad0b526210deda2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/on_startup_page/startup_url_dialog.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
scottchen
screenshot post-fix: http://imgur.com/a/8xciw
3 years, 10 months ago (2017-02-22 22:30:07 UTC) #3
hcarmona
LGTM w/ a nit: Please add the screenshot to the bug.
3 years, 10 months ago (2017-02-22 22:32:16 UTC) #4
scottchen
On 2017/02/22 22:32:16, hcarmona wrote: > LGTM w/ a nit: > > Please add the ...
3 years, 10 months ago (2017-02-22 22:54:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707383002/1
3 years, 10 months ago (2017-02-22 22:55:36 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 00:27:03 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3bf98d03dbef1c18a79d3d86cad0...

Powered by Google App Engine
This is Rietveld 408576698