Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2707313002: Gtk: Change NULL to nullptr (Closed)

Created:
3 years, 10 months ago by Tom (Use chromium acct)
Modified:
3 years, 10 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gtk: Change NULL to nullptr This CL changes all instances of NULL to nullptr in libgtkui. The process was: $ find chrome/browser/ui/libgtkui -type f | xargs sed -i 's/NULL/nullptr/g' $ git cl format In addition, remove a workaround that redefines NULL to nullptr since all references to NULL have been removed. https://cs.chromium.org/chromium/src/chrome/browser/ui/libgtkui/gtk_ui.cc?rcl=8db1658c62cfe49d1be14bc0186d4c20152cfd84&l=85 BUG=79722 R=erg@chromium.org Review-Url: https://codereview.chromium.org/2707313002 Cr-Commit-Position: refs/heads/master@{#452198} Committed: https://chromium.googlesource.com/chromium/src/+/e017cf7ef61b27d0e94380f00b78fdf7f1e1973d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -131 lines) Patch
M chrome/browser/ui/libgtkui/app_indicator_icon.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/libgtkui/app_indicator_icon_menu.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/libgtkui/chrome_gtk_frame.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/libgtkui/chrome_gtk_menu_subclasses.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/libgtkui/gconf_listener.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtkui/gconf_listener.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/libgtkui/gtk_event_loop.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/libgtkui/gtk_key_bindings_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtkui/gtk_key_bindings_handler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/libgtkui/gtk_status_icon.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtkui/gtk_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtkui/gtk_ui.cc View 6 chunks +9 lines, -16 lines 0 comments Download
M chrome/browser/ui/libgtkui/gtk_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/libgtkui/gtk_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/libgtkui/menu_util.cc View 6 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/ui/libgtkui/native_theme_gtk2.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/libgtkui/native_theme_gtk3.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtkui/print_dialog_gtk.cc View 11 chunks +25 lines, -24 lines 0 comments Download
M chrome/browser/ui/libgtkui/select_file_dialog_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/libgtkui/select_file_dialog_impl_gtk.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/libgtkui/skia_utils_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtkui/unity_service.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/libgtkui/x11_input_method_context_impl_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/libgtkui/x11_input_method_context_impl_gtk.cc View 7 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Tom (Use chromium acct)
erg PTAL This fixes the build failure on the 32 bit linux builder which caused ...
3 years, 10 months ago (2017-02-22 19:26:17 UTC) #2
Elliot Glaysher
"linux/debian_wheezy_i386-sysroot/usr/include/linux/stddef.h redefines NULL to 0, which breaks -Wsentinel." ಠ_ಠ LGTM for the fix
3 years, 10 months ago (2017-02-22 19:28:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707313002/1
3 years, 10 months ago (2017-02-22 21:00:59 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 21:08:08 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e017cf7ef61b27d0e94380f00b78...

Powered by Google App Engine
This is Rietveld 408576698