[api] Fix DescriptorInterceptor with access check.

src/objects.cc

Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index bdaffa42bb68d017477d78fb1f2ae6a843b68b23..e596ccccef871b69fa206176b50f5f275ed6e029 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -6893,6 +6893,10 @@ namespace {
 
 Maybe<bool> GetPropertyDescriptorWithInterceptor(LookupIterator* it,
                                                  PropertyDescriptor* desc) {
+  if (it->state() == LookupIterator::ACCESS_CHECK) {

[jochen (gone - plz use gerrit), 2017/02/22 11:02:41]

hum, if the state is ACCESS_CHECK we should do an access check, and if that one
failed, we need to do a lookup with failed access check (only looking at
AllCanRead properties or using the failed-access-check-interceptor)

[Franzi, 2017/02/22 17:38:51]

I wrongly assumed the interceptor would overrule the access check. 

I changed it to only intercept if has_access() or CanReadAll() is true. If not,
we return and call GetPropertyAttributes() which handles the access check. 

+    it->Next();
+  }
+
   if (it->state() == LookupIterator::INTERCEPTOR) {
     Isolate* isolate = it->isolate();
     Handle<InterceptorInfo> interceptor = it->GetInterceptor();
@@ -6937,6 +6941,7 @@ Maybe<bool> GetPropertyDescriptorWithInterceptor(LookupIterator* it,
       }
     }
   }
+  it->Restart();
   return Just(false);
 }
 }  // namespace