Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp

Issue 2707243006: [SharedArrayBuffer] Prevent SharedArrayBuffer being used in Web APIs (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp b/third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp
index c4700f0921381d9658f2fff559b5dce1aa4f4078..de19944e4c82238c7ad3681e8df27840507b261e 100644
--- a/third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp
@@ -92,10 +92,17 @@ void WaveShaperNode::setCurveImpl(const float* curveData,
getWaveShaperProcessor()->setCurve(curveData, curveLength);
}
-void WaveShaperNode::setCurve(DOMFloat32Array* curve,
+void WaveShaperNode::setCurve(const MaybeShared<DOMFloat32Array>& maybeShared,
ExceptionState& exceptionState) {
DCHECK(isMainThread());
+ if (maybeShared.isShared()) {
+ exceptionState.throwTypeError(
+ "curve should not be backed by a SharedArrayBuffer.");
+ return;
+ }
+ DOMFloat32Array* curve = maybeShared.viewNotShared();
+
if (curve)
setCurveImpl(curve->data(), curve->length(), exceptionState);
else

Powered by Google App Engine
This is Rietveld 408576698