Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2707233002: Range and Selection: Do not accept offsets larger than 2^31-1. (Closed)

Created:
3 years, 10 months ago by tkent
Modified:
3 years, 10 months ago
Reviewers:
yoichio, yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Range and Selection: Do not accept offsets larger than 2^31-1. Our code can't handle such large offsets correctly at this moment. BUG=391673, 658716 Review-Url: https://codereview.chromium.org/2707233002 Cr-Commit-Position: refs/heads/master@{#451931} Committed: https://chromium.googlesource.com/chromium/src/+/6031878959db66b36eedb04639f7124e1ab78d7c

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -10 lines) Patch
M third_party/WebKit/LayoutTests/fast/text/selection-exceptions.html View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/selection-exceptions-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Range.cpp View 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
tkent
yosin@, yoichio@, would you review this please?
3 years, 10 months ago (2017-02-22 05:40:12 UTC) #9
yosin_UTC9
lgtm
3 years, 10 months ago (2017-02-22 06:30:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707233002/20001
3 years, 10 months ago (2017-02-22 08:24:01 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 08:37:38 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6031878959db66b36eedb04639f7...

Powered by Google App Engine
This is Rietveld 408576698