Issue 270723003: PNaCl SIMD: allow the bitcode reader to read select instructions properly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 270723003: PNaCl SIMD: allow the bitcode reader to read select instructions properly (Closed)

Created:
6 years, 7 months ago by JF

Modified:
6 years, 7 months ago

Reviewers:
kschimpf, Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
http://git.chromium.org/native_client/pnacl-llvm.git@master

Visibility:
Public.

PNaCl SIMD: allow the bitcode reader to read select instructions properly Vector selects weren't handled properly by the NaCl bitcode reader but were handled properly by the LLVM one: the addition of vectors was missing tests for select with a vector mask, which had (correctly) been removed from the NaCl bitcode reader but not added back when vector support was added. R=dschuff@chromium.org, kschimpf@chromium.org TEST= (cd ./toolchain_build/out/llvm_i686_linux_work/ && ninja check-all) BUG= https://code.google.com/p/nativeclient/issues/detail?id=2205 Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=3dda707

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -3 lines)			Patch
M	lib/Bitcode/NaCl/Reader/NaClBitcodeReader.cpp	View	1 chunk	+11 lines, -3 lines	0 comments	Download
M	test/NaCl/Bitcode/vector.ll	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/NaCl/PNaClABI/instructions.ll	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Derek Schuff

LGTM. we should also try to figure out why the error message wasn't getting plumbed ...

6 years, 7 months ago (2014-05-07 18:28:05 UTC) #2

6 years, 7 months ago (2014-05-07 18:33:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r3dda707 (presubmit successful).