Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2707223003: Missing @required arg quick fix improvements. (Closed)

Created:
3 years, 10 months ago by pquitslund
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Missing @required arg quick fix improvements. * fixes missing `HintCode.MISSING_REQUIRED_PARAM_WITH_DETAILS` case * improve quick fix message (add name) * update codegen BUG= R=scheglov@google.com Fixes: #28830 Committed: https://github.com/dart-lang/sdk/commit/174a50bb896d18f54f7da9be975be080951455b5

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -16 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 3 chunks +13 lines, -14 lines 1 comment Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 3 chunks +69 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
pquitslund
3 years, 10 months ago (2017-02-22 00:36:23 UTC) #2
scheglov
I bit hackish, but I guess this is what you want for now :-) lgtm
3 years, 10 months ago (2017-02-22 01:06:42 UTC) #3
pquitslund
On 2017/02/22 01:06:42, scheglov wrote: > I bit hackish, but I guess this is what ...
3 years, 10 months ago (2017-02-22 14:41:44 UTC) #4
pquitslund
Committed patchset #1 (id:1) manually as 174a50bb896d18f54f7da9be975be080951455b5 (presubmit successful).
3 years, 10 months ago (2017-02-22 14:43:50 UTC) #6
Brian Wilkerson
3 years, 10 months ago (2017-02-22 14:50:04 UTC) #7
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/2707223003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/services/correction/fix_internal.dart (right):

https://codereview.chromium.org/2707223003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/correction/fix_internal.dart:579: return;
// and error?
No error.

Powered by Google App Engine
This is Rietveld 408576698