Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2707203007:
Add GLIB_VERSION_MAX_ALLOWED to build flags (Closed)
|
Created:
3 years, 10 months ago by Tom (Use chromium acct) Modified:
3 years, 10 months ago CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, Michael Moss, wfh+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd GLIB_VERSION_MAX_ALLOWED to build flags
Release builds with the Jessie sysroot currently have a dependency on
libglib2.0-0 (>= 2.41.1). However, the version of libglib packaged
with Trusty is only 2.40. This means users won't be able to install a
debian package on Trusty compiled with the Jessie sysroot.
This CL sets GLIB_VERSION_MAX_ALLOWED to 2.32, because that is the
version that ships with Wheezy. We can't use a later minimum glib
version because we still build with the Wheezy sysroot, and macro
versions later than GLIB_VERSION_2_32 are not defined. Keeping it at
2.32 is not harmful.
R=dpranke@chromium.org,thestig@chromium.org
Review-Url: https://codereview.chromium.org/2707203007
Cr-Commit-Position: refs/heads/master@{#452749}
Committed: https://chromium.googlesource.com/chromium/src/+/d92ddb31281a028252ed844d200fc58a0efec783
Patch Set 1 #Patch Set 2 : Rebase #
Messages
Total messages: 22 (15 generated)
reviewers ptal thestig: chrome/installer/linux/debian/expected_deps_x64_jessie dpranke: build/config/linux/BUILD.gn I've audited the rest of expected_deps_x64_jessie and everything besides libglib is available on our supported platforms.
lgtm We are fortunate that 2.32 is the version that added GLIB_VERSION_MAX_ALLOWED.
lgtm
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thomasanderson@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org, dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2707203007/#ps30001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 30001, "attempt_start_ts": 1487909117404670,
"parent_rev": "5fa975c1785e2a47c96471691447846d1be8b51d", "commit_rev":
"d92ddb31281a028252ed844d200fc58a0efec783"}
Message was sent while issue was closed.
Description was changed from ========== Add GLIB_VERSION_MAX_ALLOWED to build flags Release builds with the Jessie sysroot currently have a dependency on libglib2.0-0 (>= 2.41.1). However, the version of libglib packaged with Trusty is only 2.40. This means users won't be able to install a debian package on Trusty compiled with the Jessie sysroot. This CL sets GLIB_VERSION_MAX_ALLOWED to 2.32, because that is the version that ships with Wheezy. We can't use a later minimum glib version because we still build with the Wheezy sysroot, and macro versions later than GLIB_VERSION_2_32 are not defined. Keeping it at 2.32 is not harmful. R=dpranke@chromium.org,thestig@chromium.org ========== to ========== Add GLIB_VERSION_MAX_ALLOWED to build flags Release builds with the Jessie sysroot currently have a dependency on libglib2.0-0 (>= 2.41.1). However, the version of libglib packaged with Trusty is only 2.40. This means users won't be able to install a debian package on Trusty compiled with the Jessie sysroot. This CL sets GLIB_VERSION_MAX_ALLOWED to 2.32, because that is the version that ships with Wheezy. We can't use a later minimum glib version because we still build with the Wheezy sysroot, and macro versions later than GLIB_VERSION_2_32 are not defined. Keeping it at 2.32 is not harmful. R=dpranke@chromium.org,thestig@chromium.org Review-Url: https://codereview.chromium.org/2707203007 Cr-Commit-Position: refs/heads/master@{#452749} Committed: https://chromium.googlesource.com/chromium/src/+/d92ddb31281a028252ed844d200f... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:30001) as https://chromium.googlesource.com/chromium/src/+/d92ddb31281a028252ed844d200f... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
