Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2707203003: Merged: Squashed multiple commits. (Closed)

Created:
3 years, 10 months ago by titzer
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.7
Project:
v8
Visibility:
Public.

Description

Merged: Squashed multiple commits. This CL merges together all changes necessary to implement the correct unreachability handling in the V8 WebAssembly validation. Merged: [wasm][asm.js] Fix incorrect stack depth in some returns. Revision: 8cee1e7e17a58262b76b7fe48c2318eb2efca609 Merged: [wasm] Add a more exhaustive test for unreachable code validation. Revision: 097e1ac6c74992b47aedee4cd3c98475438a38e1 Merged: [wasm] Some simplifications in function-body-decoder.cc. Revision: aa3cd2cd0745266fe98a5fc1304a889de431bcea Merged: [wasm] Fix checking of unreachable code (clear stack after unreachable). Revision: 34b337fae6bc7c354ec76ada6e10e21e492492e4 Merged: [wasm] Unreachability fix for br_table. Revision: 04434acbcea8012236fa1105076480336c00a089 Merged: [wasm] Implement polymorphic checking, matching the reference interpreter. Revision: a9b8a5675841a616870ee053419da5937eaf66ef Merged: [wasm] Inspect right control frames for unreachable flag Revision: e2b83fbbfdf403903d3b4e5bd9276d38151789c3 BUG=None,chromium:682659,chromium:682659,chromium:682659 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=rossberg@chromium.org Review-Url: https://codereview.chromium.org/2707203003 Cr-Commit-Position: refs/branch-heads/5.7@{#126} Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426} Committed: https://chromium.googlesource.com/v8/v8/+/ede65fea09b5f584856ddf3921a7bcdba00d0f3f

Patch Set 1 #

Patch Set 2 : TypeCheckFallThru() on end. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+592 lines, -453 lines) Patch
M src/asmjs/asm-wasm-builder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/wasm/function-body-decoder.cc View 1 25 chunks +156 lines, -126 lines 0 comments Download
M src/wasm/wasm-opcodes.h View 3 chunks +5 lines, -7 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 7 chunks +25 lines, -15 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-simd.cc View 11 chunks +89 lines, -118 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-simd-lowering.cc View 14 chunks +125 lines, -142 lines 0 comments Download
M test/mjsunit/regress/wasm/regression-667745.js View 1 chunk +1 line, -28 lines 0 comments Download
M test/mjsunit/wasm/function-names.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/globals.js View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/wasm/unreachable-validation.js View 1 chunk +130 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/wasm-module-builder.js View 1 chunk +3 lines, -0 lines 0 comments Download
M test/unittests/wasm/function-body-decoder-unittest.cc View 5 chunks +56 lines, -14 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
titzer
3 years, 10 months ago (2017-02-22 14:33:08 UTC) #1
titzer
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 10 months ago (2017-02-22 14:33:10 UTC) #2
titzer
On 2017/02/22 14:33:10, titzer wrote: > NOTE: This script will no longer automatically update include/v8-version.h ...
3 years, 10 months ago (2017-02-22 14:34:40 UTC) #9
rossberg
LGTM from eyeballing
3 years, 10 months ago (2017-02-22 15:00:06 UTC) #10
Michael Hablich
On 2017/02/22 at 15:00:06, rossberg wrote: > LGTM from eyeballing rubberstamp lgtm
3 years, 10 months ago (2017-02-22 15:47:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707203003/20001
3 years, 10 months ago (2017-02-22 15:48:54 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 15:49:12 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/ede65fea09b5f584856ddf3921a7bcdba00...

Powered by Google App Engine
This is Rietveld 408576698