Use HTTPS URL for GitHub web-platform-tests repo.

Use HTTPS URL for GitHub web-platform-tests repo.

Using SSH requires setting up SSH credentials, including (as far as I
understand), having an SSH private key on the machine running the script,
and having a SSH public key registered with an account.

If possible, using HTTPS for everything might be simpler.

According to Jeff in https://chromium-review.googlesource.com/c/444149/,
using HTTPS may require adding the GitHub password for
chromium-wpt-export-bot to credentials.json on the slave in order for
it to push to WPT; I haven't confirmed this yet (but currently I believe
that this is not the case).

BUG=693651
Review-Url: https://codereview.chromium.org/2707183004
Cr-Commit-Position: refs/heads/master@{#452575}
Committed: https://chromium.googlesource.com/chromium/src/+/e7ac71359c14375a24763f56bdc75ffd2e15513a

[qyearsley, 2017-02-22 19:06:05]

qyearsley@chromium.org changed reviewers:
+ foolip@chromium.org

[qyearsley, 2017-02-22 19:08:31]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 19:09:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qyearsley, 2017-02-22 19:10:18]

Just tried merging https://github.com/w3c/web-platform-tests/pull/4957 with the
HTTPS URL, and no extra changes to the way authentication is done, and the
in-flight PR was merged successfully.

[commit-bot: I haz the power, 2017-02-22 20:59:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 20:59:57]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[qyearsley, 2017-02-22 21:05:32]

Description was changed from

==========
Use HTTPS URL for GitHub web-platform-tests repo.

Using SSH requires setting up SSH credentials, including (as far as I
understand), having an SSH private key on the machine running the script,
and having a SSH public key registered with an account.

If possible, using HTTPS for everything might be simpler.

According to Jeff in https://chromium-review.googlesource.com/c/444149/,
using HTTPS may require adding the GitHub password for
chromium-wpt-export-bot to credentials.json on the slave in order for
it to push to WPT; I haven't confirmed this yet.

BUG=693651
==========

to

==========
Use HTTPS URL for GitHub web-platform-tests repo.

Using SSH requires setting up SSH credentials, including (as far as I
understand), having an SSH private key on the machine running the script,
and having a SSH public key registered with an account.

If possible, using HTTPS for everything might be simpler.

According to Jeff in https://chromium-review.googlesource.com/c/444149/,
using HTTPS may require adding the GitHub password for
chromium-wpt-export-bot to credentials.json on the slave in order for
it to push to WPT; I haven't confirmed this yet (but currently I believe
that this is not the case).

BUG=693651
==========

[qyearsley, 2017-02-22 21:05:32]

qyearsley@chromium.org changed reviewers:
+ tkent@chromium.org

[qyearsley, 2017-02-22 21:12:58]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 21:13:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 22:22:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 22:22:31]

Dry run: This issue passed the CQ dry run.

[foolip, 2017-02-23 02:35:31]

lgtm

FWIW, I always use SSH URLs locally, because authentication over HTTPS requires
some extra steps that I've never figured out what they are.

To clone using HTTPS should be fine, but how does the push work? Maybe the token
given on the command line comes into play here, so that the SSH key isn't needed
at all?

[qyearsley, 2017-02-23 19:00:27]

On 2017/02/23 at 02:35:31, foolip wrote:
> lgtm
> 
> FWIW, I always use SSH URLs locally, because authentication over HTTPS
requires some extra steps that I've never figured out what they are.
> 
> To clone using HTTPS should be fine, but how does the push work? Maybe the
token given on the command line comes into play here, so that the SSH key isn't
needed at all?

Yeah, I'm hoping that that's the case -- the token can be given different
permissions and is passed in the headers along with the requests... so maybe
that's all that's required.

What I've confirmed so far is just that merging an existing PR works with just
the token, haven't yet confirmed that it works to make PRs :-/

[qyearsley, 2017-02-23 19:06:34]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2017-02-23 19:07:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 19:12:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487876794770440,
"parent_rev": "a7fd1c210c0914588af51971688ca1877b421c43", "commit_rev":
"e7ac71359c14375a24763f56bdc75ffd2e15513a"}

[commit-bot: I haz the power, 2017-02-23 19:13:55]

Description was changed from

==========
Use HTTPS URL for GitHub web-platform-tests repo.

Using SSH requires setting up SSH credentials, including (as far as I
understand), having an SSH private key on the machine running the script,
and having a SSH public key registered with an account.

If possible, using HTTPS for everything might be simpler.

According to Jeff in https://chromium-review.googlesource.com/c/444149/,
using HTTPS may require adding the GitHub password for
chromium-wpt-export-bot to credentials.json on the slave in order for
it to push to WPT; I haven't confirmed this yet (but currently I believe
that this is not the case).

BUG=693651
==========

to

==========
Use HTTPS URL for GitHub web-platform-tests repo.

Using SSH requires setting up SSH credentials, including (as far as I
understand), having an SSH private key on the machine running the script,
and having a SSH public key registered with an account.

If possible, using HTTPS for everything might be simpler.

According to Jeff in https://chromium-review.googlesource.com/c/444149/,
using HTTPS may require adding the GitHub password for
chromium-wpt-export-bot to credentials.json on the slave in order for
it to push to WPT; I haven't confirmed this yet (but currently I believe
that this is not the case).

BUG=693651

Review-Url: https://codereview.chromium.org/2707183004
Cr-Commit-Position: refs/heads/master@{#452575}
Committed:
https://chromium.googlesource.com/chromium/src/+/e7ac71359c14375a24763f56bdc7...
==========

[commit-bot: I haz the power, 2017-02-23 19:13:56]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e7ac71359c14375a24763f56bdc7...

[jeffcarp, 2017-02-27 21:19:44]

jeffcarp@chromium.org changed reviewers:
+ jeffcarp@chromium.org

[jeffcarp, 2017-02-27 21:19:45]

https://codereview.chromium.org/2707183004/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/common.py (right):

https://codereview.chromium.org/2707183004/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/common.py:15: WPT_GH_REPO_URL =
'https://github.com/w3c/web-platform-tests.git'
The result of this is that `git push` in local_wpt.py now expects the GitHub
username and password to be passed in via STDIN. This is causing the exporter to
break locally when trying to export a commit.

Fortunately what we can do is use the GitHub API token (which we already have
via the credentials JSON) in the origin name like so:

'https://{github_api_token}@github.com/w3c/web-platform-tests.git'.format(github_api_token='0xdecafbad')

I'm using this method locally to export a few commits that are in the pipeline.
I'll make a CL to update this git origin URL to work everywhere.

[qyearsley, 2017-02-27 21:40:55]

On 2017/02/27 at 21:19:45, jeffcarp wrote:
>
https://codereview.chromium.org/2707183004/diff/20001/third_party/WebKit/Tool...
> File third_party/WebKit/Tools/Scripts/webkitpy/w3c/common.py (right):
> 
>
https://codereview.chromium.org/2707183004/diff/20001/third_party/WebKit/Tool...
> third_party/WebKit/Tools/Scripts/webkitpy/w3c/common.py:15: WPT_GH_REPO_URL =
'https://github.com/w3c/web-platform-tests.git'
> The result of this is that `git push` in local_wpt.py now expects the GitHub
username and password to be passed in via STDIN. This is causing the exporter to
break locally when trying to export a commit.
> 
> Fortunately what we can do is use the GitHub API token (which we already have
via the credentials JSON) in the origin name like so:
> 
>
'https://{github_api_token}@github.com/w3c/web-platform-tests.git'.format(github_api_token='0xdecafbad')
> 
> I'm using this method locally to export a few commits that are in the
pipeline. I'll make a CL to update this git origin URL to work everywhere.

Awesome, thanks -- the only documentation I found that seems to talk about this
is:
https://github.com/blog/1270-easier-builds-and-deployments-using-git-over-htt...

[jeffcarp, 2017-02-27 21:53:25]

On 2017/02/27 at 21:40:55, qyearsley wrote:
> On 2017/02/27 at 21:19:45, jeffcarp wrote:
> >
https://codereview.chromium.org/2707183004/diff/20001/third_party/WebKit/Tool...
> > File third_party/WebKit/Tools/Scripts/webkitpy/w3c/common.py (right):
> > 
> >
https://codereview.chromium.org/2707183004/diff/20001/third_party/WebKit/Tool...
> > third_party/WebKit/Tools/Scripts/webkitpy/w3c/common.py:15: WPT_GH_REPO_URL
= 'https://github.com/w3c/web-platform-tests.git'
> > The result of this is that `git push` in local_wpt.py now expects the GitHub
username and password to be passed in via STDIN. This is causing the exporter to
break locally when trying to export a commit.
> > 
> > Fortunately what we can do is use the GitHub API token (which we already
have via the credentials JSON) in the origin name like so:
> > 
> >
'https://{github_api_token}@github.com/w3c/web-platform-tests.git'.format(github_api_token='0xdecafbad')
> > 
> > I'm using this method locally to export a few commits that are in the
pipeline. I'll make a CL to update this git origin URL to work everywhere.
> 
> Awesome, thanks -- the only documentation I found that seems to talk about
this is:
https://github.com/blog/1270-easier-builds-and-deployments-using-git-over-htt...

CL is up https://codereview.chromium.org/2719173002