Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2707133008: Revert of Make document.rootScroller into an origin trial (Closed)

Created:
3 years, 10 months ago by bokan
Modified:
3 years, 9 months ago
Reviewers:
iclelland, Rick Byers
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, kinuko+watch, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make document.rootScroller into an origin trial (patchset #3 id:40001 of https://codereview.chromium.org/2628923002/ ) Reason for revert: Origin trial has been delayed for now Original issue's description: > Make document.rootScroller into an origin trial > > Intent-to-experiment: > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/COF0YKkjZVQ > > BUG=680190 > > Review-Url: https://codereview.chromium.org/2628923002 > Cr-Commit-Position: refs/heads/master@{#443956} > Committed: https://chromium.googlesource.com/chromium/src/+/f2b6b4c6b17f90d48d986c3856f4a422ddbdbc2c TBR=iclelland@chromium.org,rbyers@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=680190 Review-Url: https://codereview.chromium.org/2707133008 Cr-Commit-Position: refs/heads/master@{#453905} Committed: https://chromium.googlesource.com/chromium/src/+/a36b3b3314dd80ef22d20cc86f3146767b7e23b1

Patch Set 1 #

Total comments: 1

Patch Set 2 : Manual Revert #

Patch Set 3 : Build fix #

Patch Set 4 : Removed webexposed tests #

Messages

Total messages: 26 (15 generated)
bokan
Created Revert of Make document.rootScroller into an origin trial
3 years, 10 months ago (2017-02-23 14:46:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707133008/1
3 years, 10 months ago (2017-02-23 14:47:01 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/361808)
3 years, 10 months ago (2017-02-23 14:49:03 UTC) #5
iclelland
https://codereview.chromium.org/2707133008/diff/1/third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp File third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp (left): https://codereview.chromium.org/2707133008/diff/1/third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp#oldcode53 third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp:53: prototypeObject, interfaceObject); This code was moved recently, into third_party/WebKit/Source/bindings/core/v8/ConditionalFeaturesForCore.cpp ...
3 years, 10 months ago (2017-02-23 15:46:40 UTC) #6
bokan
On 2017/02/23 15:46:40, iclelland wrote: > https://codereview.chromium.org/2707133008/diff/1/third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp > File third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp (left): > > https://codereview.chromium.org/2707133008/diff/1/third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp#oldcode53 > ...
3 years, 9 months ago (2017-02-28 15:29:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707133008/100001
3 years, 9 months ago (2017-02-28 15:29:34 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/23605)
3 years, 9 months ago (2017-02-28 15:40:57 UTC) #11
bokan
Ian, seems that the logic got dup'd so it's more than just a mechanical removal ...
3 years, 9 months ago (2017-02-28 16:01:04 UTC) #14
iclelland
On 2017/02/28 16:01:04, bokan wrote: > Ian, seems that the logic got dup'd so it's ...
3 years, 9 months ago (2017-03-01 03:52:48 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707133008/140001
3 years, 9 months ago (2017-03-01 11:32:32 UTC) #23
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 11:36:44 UTC) #26
Message was sent while issue was closed.
Committed patchset #4 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/a36b3b3314dd80ef22d20cc86f31...

Powered by Google App Engine
This is Rietveld 408576698