Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/361808)
3 years, 10 months ago
(2017-02-23 14:49:03 UTC)
#5
https://codereview.chromium.org/2707133008/diff/1/third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp File third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp (left): https://codereview.chromium.org/2707133008/diff/1/third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp#oldcode53 third_party/WebKit/Source/bindings/core/v8/ConditionalFeatures.cpp:53: prototypeObject, interfaceObject); This code was moved recently, into third_party/WebKit/Source/bindings/core/v8/ConditionalFeaturesForCore.cpp ...
3 years, 10 months ago
(2017-02-23 15:46:40 UTC)
#6
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/23605)
3 years, 9 months ago
(2017-02-28 15:40:57 UTC)
#11
Ian, seems that the logic got dup'd so it's more than just a mechanical removal ...
3 years, 9 months ago
(2017-02-28 16:01:04 UTC)
#14
Ian, seems that the logic got dup'd so it's more than just a mechanical removal
of code added in the original CL. Mind doing a quick sanity check before I land?
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago
(2017-02-28 17:59:29 UTC)
#15
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/397257)
3 years, 9 months ago
(2017-02-28 17:59:30 UTC)
#16
3 years, 9 months ago
(2017-02-28 20:33:41 UTC)
#20
Dry run: This issue passed the CQ dry run.
iclelland
On 2017/02/28 16:01:04, bokan wrote: > Ian, seems that the logic got dup'd so it's ...
3 years, 9 months ago
(2017-03-01 03:52:48 UTC)
#21
On 2017/02/28 16:01:04, bokan wrote:
> Ian, seems that the logic got dup'd so it's more than just a mechanical
removal
> of code added in the original CL. Mind doing a quick sanity check before I
land?
You got hit by 2 refactors and a test suite in just a 3-file change, wow...
This LGTM now, thanks.
bokan
The CQ bit was checked by bokan@chromium.org
3 years, 9 months ago
(2017-03-01 11:32:22 UTC)
#22
Issue 2707133008: Revert of Make document.rootScroller into an origin trial
(Closed)
Created 3 years, 10 months ago by bokan
Modified 3 years, 9 months ago
Reviewers: iclelland, Rick Byers
Base URL:
Comments: 1