|
|
Chromium Code Reviews|
Created:
3 years, 10 months ago by Primiano Tucci (use gerrit) Modified:
3 years, 10 months ago CC:
chromium-reviews, vmpstr+watch_chromium.org, mrefaat Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptiontest: disable LoggingTest.CheckCausesDistinctBreakpoints on iOS
Follow up to crrev.com/2705053002 .
The test seems to break iOS. Disabling the test, given that the
actual change to logging.h does not affect iOS.
BUG=694655
Review-Url: https://codereview.chromium.org/2707123002
Cr-Commit-Position: refs/heads/master@{#451840}
Committed: https://chromium.googlesource.com/chromium/src/+/b4da3caa626c8a43cfe73a1f415d1edf58ebb35b
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
The CQ bit was checked by primiano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
primiano@chromium.org changed reviewers: + mark@chromium.org
Mark, can you tick commit if this LGTY? mrefaat@ this should make iOS green again. If for any reason this one doesn't land revert the original CL.
LGTM
The CQ bit was unchecked by mark@chromium.org
The CQ bit was checked by mark@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by mrefaat@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by mrefaat@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487712130683830, "parent_rev":
"7161f0e4a74110c45b7ca11fd3292a8c3ea7b965", "commit_rev":
"b4da3caa626c8a43cfe73a1f415d1edf58ebb35b"}
Message was sent while issue was closed.
Description was changed from ========== test: disable LoggingTest.CheckCausesDistinctBreakpoints on iOS Follow up to crrev.com/2705053002 . The test seems to break iOS. Disabling the test, given that the actual change to logging.h does not affect iOS. BUG=694655 ========== to ========== test: disable LoggingTest.CheckCausesDistinctBreakpoints on iOS Follow up to crrev.com/2705053002 . The test seems to break iOS. Disabling the test, given that the actual change to logging.h does not affect iOS. BUG=694655 Review-Url: https://codereview.chromium.org/2707123002 Cr-Commit-Position: refs/heads/master@{#451840} Committed: https://chromium.googlesource.com/chromium/src/+/b4da3caa626c8a43cfe73a1f415d... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b4da3caa626c8a43cfe73a1f415d... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
