Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2707123002: test: disable LoggingTest.CheckCausesDistinctBreakpoints on iOS (Closed)

Created:
3 years, 10 months ago by Primiano Tucci (use gerrit)
Modified:
3 years, 10 months ago
Reviewers:
Mark Mentovai, mrefaat
CC:
chromium-reviews, vmpstr+watch_chromium.org, mrefaat
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

test: disable LoggingTest.CheckCausesDistinctBreakpoints on iOS Follow up to crrev.com/2705053002 . The test seems to break iOS. Disabling the test, given that the actual change to logging.h does not affect iOS. BUG=694655 Review-Url: https://codereview.chromium.org/2707123002 Cr-Commit-Position: refs/heads/master@{#451840} Committed: https://chromium.googlesource.com/chromium/src/+/b4da3caa626c8a43cfe73a1f415d1edf58ebb35b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/logging_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
Primiano Tucci (use gerrit)
Mark, can you tick commit if this LGTY? mrefaat@ this should make iOS green again. ...
3 years, 10 months ago (2017-02-21 18:52:59 UTC) #4
Mark Mentovai
LGTM
3 years, 10 months ago (2017-02-21 18:56:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707123002/1
3 years, 10 months ago (2017-02-21 18:57:40 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-21 20:54:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707123002/1
3 years, 10 months ago (2017-02-21 20:57:13 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-21 21:05:02 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707123002/1
3 years, 10 months ago (2017-02-21 21:23:21 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 21:51:16 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b4da3caa626c8a43cfe73a1f415d...

Powered by Google App Engine
This is Rietveld 408576698