Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 2707113006: [ios] Add new ntp histogram type. (Closed)

Created:
3 years, 10 months ago by justincohen
Modified:
3 years, 10 months ago
Reviewers:
kkhorimoto, lpromero
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, asvitkine+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Add new ntp histogram type. BUG=694808 Review-Url: https://codereview.chromium.org/2707113006 Cr-Commit-Position: refs/heads/master@{#452145} Committed: https://chromium.googlesource.com/chromium/src/+/454a93cffb64135a92ba1d8b282be7d1d45f07df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ios/chrome/browser/metrics/new_tab_page_uma.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
justincohen
Upstream CL for downstream NTP histogram change.
3 years, 10 months ago (2017-02-22 12:42:45 UTC) #2
justincohen
ptal!
3 years, 10 months ago (2017-02-22 12:42:55 UTC) #3
kkhorimoto
lgtm
3 years, 10 months ago (2017-02-22 18:13:23 UTC) #4
lpromero
lgtm
3 years, 10 months ago (2017-02-22 18:21:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707113006/1
3 years, 10 months ago (2017-02-22 18:21:47 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 18:48:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/454a93cffb64135a92ba1d8b282b...

Powered by Google App Engine
This is Rietveld 408576698