Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 2707113005: The security check in document.write should test for same-origin (Closed)

Created:
3 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 10 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The security check in document.write should test for same-origin Forgot to change this in https://codereview.chromium.org/2691083006 BUG=693819 R=mkwst@chromium.org Review-Url: https://codereview.chromium.org/2707113005 Cr-Commit-Position: refs/heads/master@{#452017} Committed: https://chromium.googlesource.com/chromium/src/+/0d3e50126e2d830e0468ed77d0a99ff42635aa25

Patch Set 1 #

Patch Set 2 : updates #

Messages

Total messages: 16 (11 generated)
jochen (gone - plz use gerrit)
3 years, 10 months ago (2017-02-22 08:54:19 UTC) #1
Mike West
Code change LGTM. Is there a test you could add?
3 years, 10 months ago (2017-02-22 09:43:17 UTC) #4
jochen (gone - plz use gerrit)
https://github.com/w3c/web-platform-tests/pull/4954
3 years, 10 months ago (2017-02-22 10:22:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707113005/20001
3 years, 10 months ago (2017-02-22 12:17:42 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 12:52:53 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0d3e50126e2d830e0468ed77d0a9...

Powered by Google App Engine
This is Rietveld 408576698