Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2707113003: Add "customPropertiesApplied" metric to StyleResolverStats. (Closed)

Created:
3 years, 10 months ago by shans
Modified:
3 years, 9 months ago
Reviewers:
meade_UTC10, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add "customPropertiesApplied" metric to StyleResolverStats. To see this in traces you need to opt into the blink_style category. This metric will then indicate how many custom properties are applied for each call to updateStyle. BUG=694902 Review-Url: https://codereview.chromium.org/2707113003 Cr-Commit-Position: refs/heads/master@{#453862} Committed: https://chromium.googlesource.com/chromium/src/+/e58eb32c10cbbdd164b40ba58c5affb2a4140490

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolverStats.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolverStats.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
shans
3 years, 10 months ago (2017-02-22 21:17:40 UTC) #2
rune
lgtm
3 years, 9 months ago (2017-02-28 11:43:13 UTC) #4
meade_UTC10
lgtm
3 years, 9 months ago (2017-02-28 23:00:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707113003/1
3 years, 9 months ago (2017-03-01 04:33:09 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 06:20:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e58eb32c10cbbdd164b40ba58c5a...

Powered by Google App Engine
This is Rietveld 408576698