[devil] Add an iteration timeout option to cmd_helper.IterCmdStdoutLines.

[devil] Add an iteration timeout option to cmd_helper.IterCmdStdoutLines.

This allows a client to specify a number of seconds after which
IterCmdStdoutLines should yield None if no complete line has been found.
It also adds an iter_timeout to LogcatMonitor s.t. it can check if a
client has asked it to stop.

BUG=chromium:693203
Review-Url: https://codereview.chromium.org/2707113002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/2a8c7dec45edea0dc03318ae626702ecee564c81

[jbudorick, 2017-02-21 18:20:10]

jbudorick@chromium.org changed reviewers:
+ bpastene@chromium.org, mikecase@chromium.org

[mikecase (-- gone --), 2017-02-21 18:52:31]

This all lgtm

https://codereview.chromium.org/2707113002/diff/1/devil/devil/android/sdk/adb...
File devil/devil/android/sdk/adb_wrapper.py (right):

https://codereview.chromium.org/2707113002/diff/1/devil/devil/android/sdk/adb...
devil/devil/android/sdk/adb_wrapper.py:569: seconds to wait between iterations.
If no line is found before the
nit: First sentence is sentence fragment. "If set and neither clear nor dump is
set, then this is the number..."

https://codereview.chromium.org/2707113002/diff/1/devil/devil/utils/cmd_helpe...
File devil/devil/utils/cmd_helper.py (right):

https://codereview.chromium.org/2707113002/diff/1/devil/devil/utils/cmd_helpe...
devil/devil/utils/cmd_helper.py:217: buffer_size=4096, poll_interval=1):
not super important since it doesnt look like anything sets poll_interval value.
but might want to add some doc about the fact that if

iter_timeout < poll_interval then poll_interval will be overridden to
iter_timeout.

Doesnt seem that impoortant though.

https://codereview.chromium.org/2707113002/diff/1/devil/devil/utils/cmd_helpe...
devil/devil/utils/cmd_helper.py:349: assert data is not None, (
I do think its kinda weird that this timeout has to sync up with the timeout in
_IterProcessStdout. I read through the code a bit and pretty sure everything
works. Just kinda confusing.

[jbudorick, 2017-02-21 21:02:54]

https://codereview.chromium.org/2707113002/diff/1/devil/devil/android/sdk/adb...
File devil/devil/android/sdk/adb_wrapper.py (right):

https://codereview.chromium.org/2707113002/diff/1/devil/devil/android/sdk/adb...
devil/devil/android/sdk/adb_wrapper.py:569: seconds to wait between iterations.
If no line is found before the
On 2017/02/21 18:52:30, mikecase wrote:
> nit: First sentence is sentence fragment. "If set and neither clear nor dump
is
> set, then this is the number..."

I appreciate your careful reading for grammar, but most of the docstrings for
arguments in this *file* are sentence fragments. As such, I'd rather be
consistent in this CL and then separately address it across the board if we
think doing so is warranted.

https://codereview.chromium.org/2707113002/diff/1/devil/devil/utils/cmd_helpe...
File devil/devil/utils/cmd_helper.py (right):

https://codereview.chromium.org/2707113002/diff/1/devil/devil/utils/cmd_helpe...
devil/devil/utils/cmd_helper.py:217: buffer_size=4096, poll_interval=1):
On 2017/02/21 18:52:31, mikecase wrote:
> not super important since it doesnt look like anything sets poll_interval
value.
> but might want to add some doc about the fact that if
> 
> iter_timeout < poll_interval then poll_interval will be overridden to
> iter_timeout.
> 
> Doesnt seem that impoortant though.

Done. Also regenerated the md docs.

[jbudorick, 2017-02-22 00:25:40]

The CQ bit was checked by jbudorick@chromium.org

[jbudorick, 2017-02-22 00:25:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
mikecase@chromium.org
Link to the patchset: https://codereview.chromium.org/2707113002/#ps20001
(title: "mikecase comments")

[commit-bot: I haz the power, 2017-02-22 00:25:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 00:48:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487723140876610,
"parent_rev": "45ec42324d1307621723153631c8499aafe9e7d4", "commit_rev":
"2a8c7dec45edea0dc03318ae626702ecee564c81"}

[commit-bot: I haz the power, 2017-02-22 00:48:07]

Description was changed from

==========
[devil] Add an iteration timeout option to cmd_helper.IterCmdStdoutLines.

This allows a client to specify a number of seconds after which
IterCmdStdoutLines should yield None if no complete line has been found.
It also adds an iter_timeout to LogcatMonitor s.t. it can check if a
client has asked it to stop.

BUG=chromium:693203
==========

to

==========
[devil] Add an iteration timeout option to cmd_helper.IterCmdStdoutLines.

This allows a client to specify a number of seconds after which
IterCmdStdoutLines should yield None if no complete line has been found.
It also adds an iter_timeout to LogcatMonitor s.t. it can check if a
client has asked it to stop.

BUG=chromium:693203

Review-Url: https://codereview.chromium.org/2707113002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-02-22 00:48:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...