Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2707053005: precache: Fix top_resources_count + experiments. (Closed)

Created:
3 years, 10 months ago by twifkak
Modified:
3 years, 10 months ago
Reviewers:
pasko, bengr, jamartin
CC:
chromium-reviews, wifiprefetch-reviews_google.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

precache: Fix top_resources_count + experiments. top_resources_count includes resources that were excluded due to the PrecacheResourceSelection that was chosen for to the field trial group. This changes it so only selected resources get counted against that cap. Note that total_resources_count does not have this problem, so nothing needs to be fixed there. BUG=696017 Review-Url: https://codereview.chromium.org/2707053005 Cr-Commit-Position: refs/heads/master@{#453051} Committed: https://chromium.googlesource.com/chromium/src/+/3fffa417af5b70accf1fe290b60de87c419be5df

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename local variables. #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase (again). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -5 lines) Patch
M components/precache/core/precache_fetcher.cc View 1 2 3 2 chunks +9 lines, -5 lines 0 comments Download
M components/precache/core/precache_fetcher_unittest.cc View 1 2 3 1 chunk +59 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 25 (12 generated)
twifkak
3 years, 10 months ago (2017-02-22 19:26:56 UTC) #2
jamartin
lgtm
3 years, 10 months ago (2017-02-22 23:00:03 UTC) #3
jamartin
lgtm
3 years, 10 months ago (2017-02-22 23:00:05 UTC) #4
twifkak
3 years, 10 months ago (2017-02-23 00:01:00 UTC) #6
pasko
rubberstamp lgtm
3 years, 10 months ago (2017-02-24 13:48:07 UTC) #7
bengr
lgtm with nit. Also, please refer to an issue ID. https://codereview.chromium.org/2707053005/diff/1/components/precache/core/precache_fetcher.cc File components/precache/core/precache_fetcher.cc (right): https://codereview.chromium.org/2707053005/diff/1/components/precache/core/precache_fetcher.cc#newcode762 ...
3 years, 10 months ago (2017-02-24 21:04:13 UTC) #8
twifkak
Added bug id. Thanks! https://codereview.chromium.org/2707053005/diff/1/components/precache/core/precache_fetcher.cc File components/precache/core/precache_fetcher.cc (right): https://codereview.chromium.org/2707053005/diff/1/components/precache/core/precache_fetcher.cc#newcode762 components/precache/core/precache_fetcher.cc:762: ++num_included; On 2017/02/24 21:04:13, bengr ...
3 years, 10 months ago (2017-02-24 21:35:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707053005/40001
3 years, 10 months ago (2017-02-24 21:43:26 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/160100) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 10 months ago (2017-02-24 21:46:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707053005/60001
3 years, 10 months ago (2017-02-25 00:40:31 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/218754) android_cronet on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 10 months ago (2017-02-25 00:42:00 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707053005/60001
3 years, 10 months ago (2017-02-25 02:03:14 UTC) #22
commit-bot: I haz the power
3 years, 10 months ago (2017-02-25 02:41:02 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3fffa417af5b70accf1fe290b60d...

Powered by Google App Engine
This is Rietveld 408576698