Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2707043003: [debugger] add more tests to side-effect free debug evaluate. (Closed)

Created:
3 years, 10 months ago by Yang
Modified:
3 years, 9 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] add more tests to side-effect free debug evaluate. Add tests for local variables in function scopes and async features. R=jgruber@chromium.org BUG=v8:5821 Review-Url: https://codereview.chromium.org/2707043003 Cr-Commit-Position: refs/heads/master@{#43468} Committed: https://chromium.googlesource.com/v8/v8/+/7c39a838ba9a168aa89acdf899a05dd14169f61d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -0 lines) Patch
A test/debugger/debug/debug-evaluate-no-side-effect-async.js View 1 chunk +50 lines, -0 lines 0 comments Download
A test/debugger/debug/debug-evaluate-no-side-effect-iife.js View 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Yang
3 years, 10 months ago (2017-02-22 14:09:34 UTC) #1
Yang
On 2017/02/22 14:09:34, Yang wrote: ping
3 years, 9 months ago (2017-02-28 07:44:07 UTC) #7
jgruber
lgtm Sorry for the delay, forgot about this one.
3 years, 9 months ago (2017-02-28 07:52:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707043003/1
3 years, 9 months ago (2017-02-28 07:56:14 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 08:20:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7c39a838ba9a168aa89acdf899a05dd1416...

Powered by Google App Engine
This is Rietveld 408576698