Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2707033002: Media Capabilities: rename mediacapabilities module to media_capabilities. (Closed)

Created:
3 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 10 months ago
Reviewers:
chcunningham
CC:
abarth-chromium, blink-reviews, chromium-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media Capabilities: rename mediacapabilities module to media_capabilities. It was really hard to read and that prevented me from sleeping at night. BUG=690380 R=chcunningham@chromium.org Review-Url: https://codereview.chromium.org/2707033002 Cr-Commit-Position: refs/heads/master@{#451846} Committed: https://chromium.googlesource.com/chromium/src/+/f2446f652488f56771631375ee11d2396de248e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -313 lines) Patch
M third_party/WebKit/Source/modules/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/modules/media_capabilities/AudioConfiguration.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/modules/media_capabilities/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/modules/media_capabilities/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/modules/media_capabilities/MediaConfiguration.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/modules/media_capabilities/MediaDecodingAbility.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/modules/media_capabilities/MediaDecodingAbility.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/modules/media_capabilities/MediaDecodingAbility.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/modules/media_capabilities/NavigatorMediaCapabilities.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/modules/media_capabilities/NavigatorMediaCapabilities.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/modules/media_capabilities/NavigatorMediaCapabilities.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/modules/media_capabilities/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/modules/media_capabilities/VideoConfiguration.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/Source/modules/mediacapabilities/AudioConfiguration.idl View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/Source/modules/mediacapabilities/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/Source/modules/mediacapabilities/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/modules/mediacapabilities/MediaCapabilities.h View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/Source/modules/mediacapabilities/MediaCapabilities.cpp View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/Source/modules/mediacapabilities/MediaCapabilities.idl View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/modules/mediacapabilities/MediaConfiguration.idl View 1 chunk +0 lines, -17 lines 0 comments Download
D third_party/WebKit/Source/modules/mediacapabilities/MediaDecodingAbility.h View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/Source/modules/mediacapabilities/MediaDecodingAbility.cpp View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/Source/modules/mediacapabilities/MediaDecodingAbility.idl View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/Source/modules/mediacapabilities/NavigatorMediaCapabilities.h View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/Source/modules/mediacapabilities/NavigatorMediaCapabilities.cpp View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/Source/modules/mediacapabilities/NavigatorMediaCapabilities.idl View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/modules/mediacapabilities/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/modules/mediacapabilities/VideoConfiguration.idl View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 4 chunks +12 lines, -12 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
mlamouri (slow - plz ping)
PTAL. Should be trivial :)
3 years, 10 months ago (2017-02-21 15:03:10 UTC) #3
chcunningham
On 2017/02/21 15:03:10, mlamouri wrote: > PTAL. Should be trivial :) LGTM
3 years, 10 months ago (2017-02-21 18:34:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707033002/1
3 years, 10 months ago (2017-02-21 20:53:59 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 22:09:53 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f2446f652488f56771631375ee11...

Powered by Google App Engine
This is Rietveld 408576698