Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1261)

Issue 2707013003: mash: Add --use-test-config for mash_browser_tests. (Closed)

Created:
3 years, 10 months ago by sadrul
Modified:
3 years, 10 months ago
Reviewers:
kylechar, sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Add --use-test-config for mash_browser_tests. Add the test config flag, so that the window server (with x11 backend) is initialized properly (i.e. set to turn on override_redirect flag for the x11 windows it creates). This is a speculative fix for the flaky time outs in mash_browser_tests. BUG=693231 Review-Url: https://codereview.chromium.org/2707013003 Cr-Commit-Position: refs/heads/master@{#451850} Committed: https://chromium.googlesource.com/chromium/src/+/e7a4615d55bf04fad380cd6da95b0f7ffed08bfa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/test/base/mash_browser_tests_main.cc View 4 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
sadrul
3 years, 10 months ago (2017-02-21 18:52:32 UTC) #4
kylechar
lgtm
3 years, 10 months ago (2017-02-21 18:53:05 UTC) #5
sadrul
+sky@ for owner
3 years, 10 months ago (2017-02-21 18:54:55 UTC) #7
sky
LGTM
3 years, 10 months ago (2017-02-21 21:32:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707013003/1
3 years, 10 months ago (2017-02-21 21:35:32 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 22:15:17 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e7a4615d55bf04fad380cd6da95b...

Powered by Google App Engine
This is Rietveld 408576698