fasta: Use a slightly more efficient implementation for the [StackListener]s stack

fasta: Use a slightly more efficient implementation for the [StackListener]s stack

R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/fd6ebf7761f891ac4b2fbf14b05f6119f7454529

[kustermann, 2017-02-21 13:29:08]

kustermann@google.com changed reviewers:
+ ahe@google.com, vegorov@google.com

[kustermann, 2017-02-21 13:29:09]

https://codereview.chromium.org/2707003002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/stack_listener.dart (left):

https://codereview.chromium.org/2707003002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/stack_listener.dart:91: }
It's more efficient to implement stack.popList() directly instead of doing many
pop()s.

Therefore I moved the handling of NullValue into _Stack.popList().

For consistency I moved all other handling of NullValue into _Stack as well.

[ahe, 2017-02-21 14:24:35]

lgtm

https://codereview.chromium.org/2707003002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/stack_listener.dart (right):

https://codereview.chromium.org/2707003002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/stack_listener.dart:234: class _Stack<E> {
Please don't use privacy.

https://codereview.chromium.org/2707003002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/stack_listener.dart:234: class _Stack<E> {
I think you don't need the type variable. It should just be Object.

https://codereview.chromium.org/2707003002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/stack_listener.dart:235: List<E> _table = new
List<E>(8);
This type annotation isn't correct as NullValue isn't a subtype of E.

Here's how I make sure that the program doesn't have any warnings:

./xcodebuild/ReleaseX64/dart pkg/testing/bin/testing.dart
--config=pkg/front_end/test/fasta/testing.json analyze

[ahe, 2017-02-21 14:30:31]

And thank you once again!!!

[kustermann, 2017-02-22 13:59:37]

Thanks.

https://codereview.chromium.org/2707003002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/stack_listener.dart (right):

https://codereview.chromium.org/2707003002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/stack_listener.dart:234: class _Stack<E> {
On 2017/02/21 14:24:34, ahe wrote:
> I think you don't need the type variable. It should just be Object.

Done.

https://codereview.chromium.org/2707003002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/stack_listener.dart:234: class _Stack<E> {
On 2017/02/21 14:24:34, ahe wrote:
> Please don't use privacy.

Done.

https://codereview.chromium.org/2707003002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/stack_listener.dart:235: List<E> _table = new
List<E>(8);
On 2017/02/21 14:24:34, ahe wrote:
> This type annotation isn't correct as NullValue isn't a subtype of E.
> 
> Here's how I make sure that the program doesn't have any warnings:
> 
> ./xcodebuild/ReleaseX64/dart pkg/testing/bin/testing.dart
> --config=pkg/front_end/test/fasta/testing.json analyze

Thanks.

[kustermann, 2017-02-22 14:17:36]

Description was changed from

==========
fasta: Use a slightly more efficient implementation for the [StackListener]s
stack
==========

to

==========
fasta: Use a slightly more efficient implementation for the [StackListener]s
stack

R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/fd6ebf7761f891ac4b2fbf14b05f6119f7454529
==========

[kustermann, 2017-02-22 14:17:37]

Committed patchset #3 (id:40001) manually as
fd6ebf7761f891ac4b2fbf14b05f6119f7454529 (presubmit successful).