Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2706983002:
Make minimum width of tabs dynamic on iOS. (Closed)
DescriptionMake minimum width of tabs dynamic on iOS.
When in compact mode, reduce the maximum width of tabs in the tab strip.
Associated bug contains screenshot of what the new tabs look like.
BUG=694508
Review-Url: https://codereview.chromium.org/2706983002
Cr-Commit-Position: refs/heads/master@{#451760}
Committed: https://chromium.googlesource.com/chromium/src/+/15bd5e8f3ea2b94b0d55d836e5449733e4d00e38
Patch Set 1 #
Messages
Total messages: 19 (12 generated)
Description was changed from ========== Make minimum width of tabs dynamic on iOS. When in compact mode, reduce the maximum width of tabs in the tab strip. BUG=None. ========== to ========== Make minimum width of tabs dynamic on iOS. When in compact mode, reduce the maximum width of tabs in the tab strip. BUG=None. ==========
Description was changed from ========== Make minimum width of tabs dynamic on iOS. When in compact mode, reduce the maximum width of tabs in the tab strip. BUG=None. ========== to ========== Make minimum width of tabs dynamic on iOS. When in compact mode, reduce the maximum width of tabs in the tab strip. BUG=694508 ==========
jif@chromium.org changed reviewers: + pschaffner@chromium.org
ptal
lgtm lgtm
lgtm
Description was changed from ========== Make minimum width of tabs dynamic on iOS. When in compact mode, reduce the maximum width of tabs in the tab strip. BUG=694508 ========== to ========== Make minimum width of tabs dynamic on iOS. When in compact mode, reduce the maximum width of tabs in the tab strip. Associated bug contains screenshot of what the new tabs look like. BUG=694508 ==========
jif@chromium.org changed reviewers: + rohitrao@chromium.org
+rohitrao for owner approval
lgtm
The CQ bit was checked by jif@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jif@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487688572160870, "parent_rev":
"3472d1038e95d9284d64a2d524667eebdcb848b4", "commit_rev":
"15bd5e8f3ea2b94b0d55d836e5449733e4d00e38"}
Message was sent while issue was closed.
Description was changed from ========== Make minimum width of tabs dynamic on iOS. When in compact mode, reduce the maximum width of tabs in the tab strip. Associated bug contains screenshot of what the new tabs look like. BUG=694508 ========== to ========== Make minimum width of tabs dynamic on iOS. When in compact mode, reduce the maximum width of tabs in the tab strip. Associated bug contains screenshot of what the new tabs look like. BUG=694508 Review-Url: https://codereview.chromium.org/2706983002 Cr-Commit-Position: refs/heads/master@{#451760} Committed: https://chromium.googlesource.com/chromium/src/+/15bd5e8f3ea2b94b0d55d836e544... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/15bd5e8f3ea2b94b0d55d836e544... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
