Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1551)

Unified Diff: third_party/WebKit/Source/web/OpenedFrameTracker.h

Issue 2706963004: Clear opener when frame is detached. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/OpenedFrameTracker.h
diff --git a/third_party/WebKit/Source/web/OpenedFrameTracker.h b/third_party/WebKit/Source/web/OpenedFrameTracker.h
index c6be8f34dff49d117e8ae21e0e9c35e56cb27402..20073dc4237d63080908b46fccd7496b80298ce3 100644
--- a/third_party/WebKit/Source/web/OpenedFrameTracker.h
+++ b/third_party/WebKit/Source/web/OpenedFrameTracker.h
@@ -10,7 +10,6 @@
namespace blink {
-class Visitor;
class WebFrame;
// Small helper class to track the set of frames that a WebFrame has opened.
@@ -31,7 +30,8 @@ class OpenedFrameTracker {
// opener for opened frames to point to the new frame being swapped in.
void transferTo(WebFrame*);
- void traceFrames(Visitor*);
+ // Helper function to clear the openers when the frame is being detached.
+ void detach() { transferTo(nullptr); }
dcheng 2017/02/21 21:59:37 Nit: call this dispose().
lfg 2017/02/21 22:04:50 Done.
private:
WTF::HashSet<WebFrame*> m_openedFrames;

Powered by Google App Engine
This is Rietveld 408576698