Remove some unused cloud print histograms.

Remove some unused cloud print histograms.

BUG=643570
Review-Url: https://codereview.chromium.org/2706943003
Cr-Commit-Position: refs/heads/master@{#452527}
Committed: https://chromium.googlesource.com/chromium/src/+/f302b212b55f72414133fb3d7de74a809d85d933

[Vitaly Buka corp, 2017-02-21 07:23:32]

The CQ bit was checked by vitalybuka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 07:23:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Vitaly Buka corp, 2017-02-21 07:46:15]

vitalybuka@google.com changed reviewers:
+ mkwst@chromium.org

[Vitaly Buka corp, 2017-02-21 07:46:23]

The CQ bit was checked by vitalybuka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 07:46:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Vitaly Buka corp, 2017-02-21 07:48:38]

Description was changed from

==========
Remove some unused cloud print histograms.

BUG=643570
==========

to

==========
Remove some unused cloud print histograms.

BUG=643570
==========

[Vitaly Buka corp, 2017-02-21 07:48:38]

vitalybuka@google.com changed reviewers:
+ asvitkine@chromium.org
- mkwst@chromium.org, vitalybuka@google.com

[commit-bot: I haz the power, 2017-02-21 09:26:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 09:26:54]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Vitaly Buka (NO REVIEWS), 2017-02-21 09:53:22]

The CQ bit was checked by vitalybuka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 09:53:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 11:26:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 11:26:58]

Dry run: This issue passed the CQ dry run.

[Vitaly Buka (NO REVIEWS), 2017-02-22 23:28:03]

vitalybuka@chromium.org changed reviewers:
+ thestig@chromium.org

[Alexei Svitkine (slow), 2017-02-23 00:04:46]

Thanks for the cleanup. Please mark them as <obsolete> in the XML file
instead of deleting them since the file is used to decode data from old
versions.

On Feb 22, 2017 6:28 PM, "vitalybuka@chromium.org via
codereview.chromium.org" <reply@chromiumcodereview-hr.appspotmail.com>
wrote:

> Reviewers: Alexei Svitkine (slow), Lei Zhang (super slow)
> CL: https://codereview.chromium.org/2706943003/
>
> Description:
> Remove some unused cloud print histograms.
>
> BUG=643570
>
> Affected files (+0, -73 lines):
> M chrome/service/cloud_print/connector_settings.cc
> M chrome/service/cloud_print/printer_job_handler.h
> M chrome/service/cloud_print/printer_job_handler.cc
> M chrome/service/service_utility_process_host.h
> M chrome/service/service_utility_process_host.cc
> M tools/metrics/histograms/histograms.xml
>
>
> Index: chrome/service/cloud_print/connector_settings.cc
> diff --git a/chrome/service/cloud_print/connector_settings.cc
> b/chrome/service/cloud_print/connector_settings.cc
> index 672d544752875a9921858cf13ef8fb27c32c126f..
> 83a4617e828768f40057a2c3c7fcd7aedbb6927a 100644
> --- a/chrome/service/cloud_print/connector_settings.cc
> +++ b/chrome/service/cloud_print/connector_settings.cc
> @@ -67,9 +67,6 @@ void ConnectorSettings::InitFrom(ServiceProcessPrefs*
> prefs) {
> int timeout = prefs->GetInt(
> prefs::kCloudPrintXmppPingTimeout, kDefaultXmppPingTimeoutSecs);
> SetXmppPingTimeoutSec(timeout);
> - UMA_HISTOGRAM_LONG_TIMES(
> - "CloudPrint.XmppTimeout",
> - base::TimeDelta::FromSeconds(xmpp_ping_timeout_sec_));
>
> const base::ListValue* printers = prefs->GetList(prefs::
> kCloudPrintPrinters);
> if (printers) {
> Index: chrome/service/cloud_print/printer_job_handler.cc
> diff --git a/chrome/service/cloud_print/printer_job_handler.cc
> b/chrome/service/cloud_print/printer_job_handler.cc
> index 7799342c32b22abfeec9266ba1498334ef76018e..
> d2ea9b0b4b3c73590c6a523cd663bcda444f771b 100644
> --- a/chrome/service/cloud_print/printer_job_handler.cc
> +++ b/chrome/service/cloud_print/printer_job_handler.cc
> @@ -720,15 +720,6 @@ void PrinterJobHandler::OnReceivePrinterCaps(
> cp_tag_wildcard += ".*";
> net::AddMultipartValueForUpload(kPrinterRemoveTagValue,
> cp_tag_wildcard, mime_boundary, std::string(), &post_data);
> -
> - if (!last_caps_update_time_.is_null()) {
> - UMA_HISTOGRAM_CUSTOM_TIMES(
> - "CloudPrint.CapsUpdateInterval",
> - base::Time::Now() - last_caps_update_time_,
> - base::TimeDelta::FromMilliseconds(1),
> - base::TimeDelta::FromDays(7), 50);
> - }
> - last_caps_update_time_ = base::Time::Now();
> }
>
> if (printer_info.printer_name != printer_info_.printer_name) {
> Index: chrome/service/cloud_print/printer_job_handler.h
> diff --git a/chrome/service/cloud_print/printer_job_handler.h
> b/chrome/service/cloud_print/printer_job_handler.h
> index 6fea76b19cf61ba861126a86c950c2fa685d8097..
> fa8f1dd06f1401f1c8859b8084a6e31f013e4806 100644
> --- a/chrome/service/cloud_print/printer_job_handler.h
> +++ b/chrome/service/cloud_print/printer_job_handler.h
> @@ -303,7 +303,6 @@ class PrinterJobHandler : public
> base::RefCountedThreadSafe<PrinterJobHandler>,
>
> base::Time job_start_time_;
> base::Time spooling_start_time_;
> - base::Time last_caps_update_time_;
>
> base::WeakPtrFactory<PrinterJobHandler> weak_ptr_factory_;
>
> Index: chrome/service/service_utility_process_host.cc
> diff --git a/chrome/service/service_utility_process_host.cc
> b/chrome/service/service_utility_process_host.cc
> index 69b8a8d7f5c940a327738bc8521ba5e84b765225..
> f779bb24bc709bb8db3e78f17c49deccacf26de9 100644
> --- a/chrome/service/service_utility_process_host.cc
> +++ b/chrome/service/service_utility_process_host.cc
> @@ -182,7 +182,6 @@ bool ServiceUtilityProcessHost::
> StartRenderPDFPagesToMetafile(
> const base::FilePath& pdf_path,
> const printing::PdfRenderSettings& render_settings) {
> ReportUmaEvent(SERVICE_UTILITY_METAFILE_REQUEST);
> - start_time_ = base::Time::Now();
> base::File pdf_file(pdf_path, base::File::FLAG_OPEN |
> base::File::FLAG_READ |
> base::File::FLAG_DELETE_ON_CLOSE);
> if (!pdf_file.IsValid() || !StartProcess(false))
> @@ -198,7 +197,6 @@ bool ServiceUtilityProcessHost::
> StartRenderPDFPagesToMetafile(
> bool ServiceUtilityProcessHost::StartGetPrinterCapsAndDefaults(
> const std::string& printer_name) {
> ReportUmaEvent(SERVICE_UTILITY_CAPS_REQUEST);
> - start_time_ = base::Time::Now();
> if (!StartProcess(true))
> return false;
> DCHECK(!waiting_for_reply_);
> @@ -209,7 +207,6 @@ bool ServiceUtilityProcessHost::
> StartGetPrinterCapsAndDefaults(
> bool ServiceUtilityProcessHost::StartGetPrinterSemanticCapsAndDefaults(
> const std::string& printer_name) {
> ReportUmaEvent(SERVICE_UTILITY_SEMANTIC_CAPS_REQUEST);
> - start_time_ = base::Time::Now();
> if (!StartProcess(true))
> return false;
> DCHECK(!waiting_for_reply_);
> @@ -301,8 +298,6 @@ void ServiceUtilityProcessHost::OnChildDisconnected()
> {
> client_task_runner_->PostTask(
> FROM_HERE, base::Bind(&Client::OnChildDied, client_.get()));
> ReportUmaEvent(SERVICE_UTILITY_DISCONNECTED);
> - UMA_HISTOGRAM_TIMES("CloudPrint.ServiceUtilityDisconnectTime",
> - base::Time::Now() - start_time_);
> }
> delete this;
> }
> @@ -372,12 +367,8 @@ void ServiceUtilityProcessHost::OnPDFToEmfFinished(bool
> success) {
> waiting_for_reply_ = false;
> if (success) {
> ReportUmaEvent(SERVICE_UTILITY_METAFILE_SUCCEEDED);
> - UMA_HISTOGRAM_TIMES("CloudPrint.ServiceUtilityMetafileTime",
> - base::Time::Now() - start_time_);
> } else {
> ReportUmaEvent(SERVICE_UTILITY_METAFILE_FAILED);
> - UMA_HISTOGRAM_TIMES("CloudPrint.ServiceUtilityMetafileFailTime",
> - base::Time::Now() - start_time_);
> }
> client_task_runner_->PostTask(
> FROM_HERE, base::Bind(&Client::OnRenderPDFPagesToMetafileDone,
> @@ -390,8 +381,6 @@ void ServiceUtilityProcessHost::
> OnGetPrinterCapsAndDefaultsSucceeded(
> const printing::PrinterCapsAndDefaults& caps_and_defaults) {
> DCHECK(waiting_for_reply_);
> ReportUmaEvent(SERVICE_UTILITY_CAPS_SUCCEEDED);
> - UMA_HISTOGRAM_TIMES("CloudPrint.ServiceUtilityCapsTime",
> - base::Time::Now() - start_time_);
> waiting_for_reply_ = false;
> client_task_runner_->PostTask(
> FROM_HERE, base::Bind(&Client::OnGetPrinterCapsAndDefaults, client_.get(),
> @@ -403,8 +392,6 @@ void ServiceUtilityProcessHost::
> OnGetPrinterSemanticCapsAndDefaultsSucceeded(
> const printing::PrinterSemanticCapsAndDefaults& caps_and_defaults) {
> DCHECK(waiting_for_reply_);
> ReportUmaEvent(SERVICE_UTILITY_SEMANTIC_CAPS_SUCCEEDED);
> - UMA_HISTOGRAM_TIMES("CloudPrint.ServiceUtilitySemanticCapsTime",
> - base::Time::Now() - start_time_);
> waiting_for_reply_ = false;
> client_task_runner_->PostTask(
> FROM_HERE,
> @@ -416,8 +403,6 @@ void ServiceUtilityProcessHost::
> OnGetPrinterCapsAndDefaultsFailed(
> const std::string& printer_name) {
> DCHECK(waiting_for_reply_);
> ReportUmaEvent(SERVICE_UTILITY_CAPS_FAILED);
> - UMA_HISTOGRAM_TIMES("CloudPrint.ServiceUtilityCapsFailTime",
> - base::Time::Now() - start_time_);
> waiting_for_reply_ = false;
> client_task_runner_->PostTask(
> FROM_HERE,
> @@ -429,8 +414,6 @@ void ServiceUtilityProcessHost::
> OnGetPrinterSemanticCapsAndDefaultsFailed(
> const std::string& printer_name) {
> DCHECK(waiting_for_reply_);
> ReportUmaEvent(SERVICE_UTILITY_SEMANTIC_CAPS_FAILED);
> - UMA_HISTOGRAM_TIMES("CloudPrint.ServiceUtilitySemanticCapsFailTime",
> - base::Time::Now() - start_time_);
> waiting_for_reply_ = false;
> client_task_runner_->PostTask(
> FROM_HERE, base::Bind(&Client::OnGetPrinterSemanticCapsAndDefaults,
> Index: chrome/service/service_utility_process_host.h
> diff --git a/chrome/service/service_utility_process_host.h
> b/chrome/service/service_utility_process_host.h
> index 7fc9ab8814b0d729ed6b3e4d83c34bb6c43c3350..
> 80f9141b458f7fc10c8d2c8951268ba4d3bedf27 100644
> --- a/chrome/service/service_utility_process_host.h
> +++ b/chrome/service/service_utility_process_host.h
> @@ -150,9 +150,6 @@ class ServiceUtilityProcessHost : public
content::ChildProcessHostDelegate
> {
> bool waiting_for_reply_;
> mojo::edk::PendingProcessConnection process_connection_;
>
> - // Start time of operation.
> - base::Time start_time_;
> -
> class PdfToEmfState;
> std::unique_ptr<PdfToEmfState> pdf_to_emf_state_;
>
> Index: tools/metrics/histograms/histograms.xml
> diff --git a/tools/metrics/histograms/histograms.xml
> b/tools/metrics/histograms/histograms.xml
> index f7fd8937c039f19f0327adf824671dab93cf2849..
> 545bfbe3422da74854cd578553d71c3b9f1aaa8c 100644
> --- a/tools/metrics/histograms/histograms.xml
> +++ b/tools/metrics/histograms/histograms.xml
> @@ -7020,46 +7020,6 @@ http://cs/file:chrome/histograms.xml - but prefer
> this file for new entries.
> <summary>Event counts in ServiceProcessControl.</summary>
> </histogram>
>
> -<histogram name="CloudPrint.ServiceProcessSocketLength">
> - <obsolete>
> - Deprecated as of 12/2015. Confirm assumption about socket name size.
> - http://crbug.com/466644
> - </obsolete>
> - <owner>vitalybuka@chromium.org</owner&gt;
> - <summary>
> - Temporarily histogram with size of IPC sockets in default location.
> - </summary>
> -</histogram>
> -
> -<histogram name="CloudPrint.ServiceUtilityCapsFailTime" units="ms">
> - <owner>vitalybuka@chromium.org</owner&gt;
> - <summary>
> - The amount of time used to fail to collect printer capabilities.
> - </summary>
> -</histogram>
> -
> -<histogram name="CloudPrint.ServiceUtilityCapsTime" units="ms">
> - <owner>vitalybuka@chromium.org</owner&gt;
> - <summary>The amount of time used to collect printer
> capabilities.</summary>
> -</histogram>
> -
> -<histogram name="CloudPrint.ServiceUtilityDisconnectTime" units="ms">
> - <owner>vitalybuka@chromium.org</owner&gt;
> - <summary>
> - The amount of time the utility process runs before disconnect.
> - </summary>
> -</histogram>
> -
> -<histogram name="CloudPrint.ServiceUtilityMetafileFailTime" units="ms">
> - <owner>vitalybuka@chromium.org</owner&gt;
> - <summary>The amount of time used to fail to generate metafile.</summary>
> -</histogram>
> -
> -<histogram name="CloudPrint.ServiceUtilityMetafileTime" units="ms">
> - <owner>vitalybuka@chromium.org</owner&gt;
> - <summary>The amount of time used to generate metafile.</summary>
> -</histogram>
> -
> <histogram name="CloudPrint.ServiceUtilityProcessHostEvent"
> enum="ServiceUtilityProcessHostEventType">
> <owner>vitalybuka@chromium.org</owner&gt;
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Lei Zhang, 2017-02-23 00:39:26]

lgtm

[Vitaly Buka (NO REVIEWS), 2017-02-23 02:12:35]

The CQ bit was checked by vitalybuka@chromium.org to run a CQ dry run

[Vitaly Buka (NO REVIEWS), 2017-02-23 02:12:55]

Done.

[commit-bot: I haz the power, 2017-02-23 02:13:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 03:35:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 03:35:03]

Dry run: This issue passed the CQ dry run.

[Alexei Svitkine (slow), 2017-02-23 15:20:21]

lgtm

[Vitaly Buka (NO REVIEWS), 2017-02-23 17:04:37]

The CQ bit was checked by vitalybuka@chromium.org

[Vitaly Buka (NO REVIEWS), 2017-02-23 17:04:38]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2706943003/#ps60001
(title: "Remove some unused cloud print histograms.")

[commit-bot: I haz the power, 2017-02-23 17:05:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 17:12:49]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487869477755970,
"parent_rev": "33c677f9166e1cc0343712a35b5896aaeeb625c5", "commit_rev":
"f302b212b55f72414133fb3d7de74a809d85d933"}

[commit-bot: I haz the power, 2017-02-23 17:13:24]

Description was changed from

==========
Remove some unused cloud print histograms.

BUG=643570
==========

to

==========
Remove some unused cloud print histograms.

BUG=643570

Review-Url: https://codereview.chromium.org/2706943003
Cr-Commit-Position: refs/heads/master@{#452527}
Committed:
https://chromium.googlesource.com/chromium/src/+/f302b212b55f72414133fb3d7de7...
==========

[commit-bot: I haz the power, 2017-02-23 17:13:25]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f302b212b55f72414133fb3d7de7...