chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java - Issue 2706933003: webapk: Avoid overwriting default CreationParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java

Issue 2706933003: webapk: Avoid overwriting default CreationParams

Patch Set: cleanups Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/WarmupManager.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java ('k') | chrome/browser/android/web_contents_factory.cc » ('j') | content/browser/site_instance_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java

index 1356301084fbc8f42e225ae76a13818dfeee2702..6a3ba14c749699d482ec9bd5714ba324ef3d9141 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java

@@ -14,6 +14,7 @@ import org.chromium.base.ThreadUtils;

import org.chromium.base.test.util.Feature;

import org.chromium.base.test.util.Restriction;

import org.chromium.chrome.browser.profiles.Profile;

+import org.chromium.content.browser.ChildProcessCreationParams;

import org.chromium.content.browser.test.NativeLibraryTestBase;

import org.chromium.content.browser.test.util.Criteria;

import org.chromium.content.browser.test.util.CriteriaHelper;

@@ -113,8 +114,8 @@ public class ExternalPrerenderHandlerTest extends NativeLibraryTestBase {

Callable<WebContents> addPrerenderCallable = new Callable<WebContents>() {

@Override

public WebContents call() {

- Pair<WebContents, WebContents> webContents =

- mExternalPrerenderHandler.addPrerender(mProfile, url, "", new Rect(), true);

+ Pair<WebContents, WebContents> webContents = mExternalPrerenderHandler.addPrerender(

+ mProfile, url, "", new Rect(), true, ChildProcessCreationParams.DEFAULT_ID);

assertNotNull(webContents);

assertNotNull(webContents.first);

assertNotNull(webContents.second);