chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java - Issue 2706933003: webapk: Avoid overwriting default CreationParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

Issue 2706933003: webapk: Avoid overwriting default CreationParams

Patch Set: cleanups Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/WarmupManager.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java » ('j') | content/browser/site_instance_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

index 32415fab0ef5c06076b69088fc512097a82e1f13..ca7501db269fe3ca09f9f6698345a1aa95669d7b 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java

@@ -13,6 +13,7 @@ import org.chromium.base.test.util.UrlUtils;

import org.chromium.chrome.browser.ChromeActivity;

import org.chromium.chrome.browser.WebContentsFactory;

import org.chromium.chrome.test.ChromeActivityTestCaseBase;

+import org.chromium.content.browser.ChildProcessCreationParams;

import org.chromium.content.browser.ContentView;

import org.chromium.content.browser.ContentViewCore;

import org.chromium.content.browser.test.util.Criteria;

@@ -85,7 +86,8 @@ public class SelectPopupOtherContentViewTest extends ChromeActivityTestCaseBase<

ThreadUtils.runOnUiThreadBlocking(new Runnable() {

@Override

public void run() {

- WebContents webContents = WebContentsFactory.createWebContents(false, false);

+ WebContents webContents = WebContentsFactory.createWebContents(

+ ChildProcessCreationParams.DEFAULT_ID, false, false);

WindowAndroid windowAndroid = new ActivityWindowAndroid(getActivity());

ContentViewCore contentViewCore = new ContentViewCore(getActivity(), "");