Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: chrome/browser/android/web_contents_factory.cc

Issue 2706933003: webapk: Avoid overwriting default CreationParams
Patch Set: rebase 461342 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/web_contents_factory.cc
diff --git a/chrome/browser/android/web_contents_factory.cc b/chrome/browser/android/web_contents_factory.cc
index 37a07999eb521ed68e1d2cf167202187a83cb0d5..1f8c8e6999d8044468467af99dabf075ca78d721 100644
--- a/chrome/browser/android/web_contents_factory.cc
+++ b/chrome/browser/android/web_contents_factory.cc
@@ -9,6 +9,7 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "content/public/browser/android/content_view_core.h"
+#include "content/public/browser/site_instance.h"
#include "content/public/browser/web_contents.h"
#include "jni/WebContentsFactory_jni.h"
@@ -18,6 +19,7 @@ using base::android::ScopedJavaLocalRef;
static ScopedJavaLocalRef<jobject> CreateWebContents(
JNIEnv* env,
const JavaParamRef<jclass>& clazz,
+ jint child_process_param_id,
jboolean incognito,
jboolean initially_hidden,
jboolean initialize_renderer) {
@@ -25,7 +27,8 @@ static ScopedJavaLocalRef<jobject> CreateWebContents(
if (incognito)
profile = profile->GetOffTheRecordProfile();
- content::WebContents::CreateParams params(profile);
+ content::WebContents::CreateParams params(
+ profile, content::SiteInstance::Create(profile, child_process_param_id));
params.initially_hidden = static_cast<bool>(initially_hidden);
params.initialize_renderer = static_cast<bool>(initialize_renderer);
return content::WebContents::Create(params)->GetJavaWebContents();

Powered by Google App Engine
This is Rietveld 408576698