chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java - Issue 2706933003: webapk: Avoid overwriting default CreationParams

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java

Issue 2706933003: webapk: Avoid overwriting default CreationParams

Patch Set: rebase 461342 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java ('k') | chrome/browser/android/web_contents_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java

index 328850cd41fd8ec2307cd941966e847d29d99e44..ed6d50a7f8486da108fa2a67e5803a30a0af7738 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java

@@ -19,6 +19,7 @@ import org.junit.Test;

import org.junit.runner.RunWith;

import org.chromium.base.ThreadUtils;

+import org.chromium.base.process_launcher.ChildProcessCreationParams;

import org.chromium.base.test.BaseJUnit4ClassRunner;

import org.chromium.base.test.util.Feature;

import org.chromium.base.test.util.Restriction;

@@ -128,8 +129,8 @@ public class ExternalPrerenderHandlerTest {

Callable<WebContents> addPrerenderCallable = new Callable<WebContents>() {

@Override

public WebContents call() {

- Pair<WebContents, WebContents> webContents =

- mExternalPrerenderHandler.addPrerender(mProfile, url, "", new Rect(), true);

+ Pair<WebContents, WebContents> webContents = mExternalPrerenderHandler.addPrerender(

+ mProfile, url, "", new Rect(), true, ChildProcessCreationParams.DEFAULT_ID);

Assert.assertNotNull(webContents);

Assert.assertNotNull(webContents.first);

Assert.assertNotNull(webContents.second);