Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: content/browser/service_worker/service_worker_lifetime_tracker.cc

Issue 2706923003: Add UMA for how long service workers run for. (Closed)
Patch Set: constexpr Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_lifetime_tracker.cc
diff --git a/content/browser/service_worker/service_worker_lifetime_tracker.cc b/content/browser/service_worker/service_worker_lifetime_tracker.cc
new file mode 100644
index 0000000000000000000000000000000000000000..9a69fe23f35f346af4b454c061eea27f728983bf
--- /dev/null
+++ b/content/browser/service_worker/service_worker_lifetime_tracker.cc
@@ -0,0 +1,68 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/service_worker/service_worker_lifetime_tracker.h"
+
+#include "base/bind.h"
+#include "base/time/default_tick_clock.h"
+#include "content/browser/service_worker/service_worker_metrics.h"
+
+namespace content {
+
+constexpr base::TimeDelta kTimerDuration = base::TimeDelta::FromMinutes(5);
nhiroki 2017/02/23 07:54:23 Can you add a comment about why we chose 5 mins?
falken 2017/02/23 08:18:18 Good idea. Done.
+
+ServiceWorkerLifetimeTracker::ServiceWorkerLifetimeTracker()
+ : ServiceWorkerLifetimeTracker(
+ base::WrapUnique(new base::DefaultTickClock)) {}
nhiroki 2017/02/23 07:54:23 base::MakeUnique<base::DefaultTickClock>()?
falken 2017/02/23 08:18:18 Done.
+
+ServiceWorkerLifetimeTracker::ServiceWorkerLifetimeTracker(
+ std::unique_ptr<base::TickClock> tick_clock)
+ : tick_clock_(std::move(tick_clock)),
+ timer_(tick_clock_.get()),
+ weak_factory_(this) {}
+
+ServiceWorkerLifetimeTracker::~ServiceWorkerLifetimeTracker() {}
nhiroki 2017/02/23 07:54:23 = default;
falken 2017/02/23 08:18:18 Done.
+
+void ServiceWorkerLifetimeTracker::StartTiming(int64_t version_id) {
+ DCHECK(running_workers_.find(version_id) == running_workers_.end());
nhiroki 2017/02/23 07:54:23 DCHECK(!base::ContainsKey(running_workers_, versio
falken 2017/02/23 08:18:18 Done.
+
+ running_workers_[version_id] = tick_clock_->NowTicks();
+ if (!timer_.IsRunning()) {
+ timer_.Start(FROM_HERE, kTimerDuration,
+ base::Bind(&ServiceWorkerLifetimeTracker::RecordHistograms,
+ weak_factory_.GetWeakPtr()));
nhiroki 2017/02/23 07:54:23 I wonder if we don't have to make |this| weak beca
falken 2017/02/23 08:18:18 Ah I think you're right. Done.
+ }
+}
+
+void ServiceWorkerLifetimeTracker::StopTiming(int64_t version_id) {
+ auto it = running_workers_.find(version_id);
+ // The entry may have been removed by AbortTiming.
+ if (it == running_workers_.end())
+ return;
+ ServiceWorkerMetrics::RecordRuntime(tick_clock_->NowTicks() - it->second);
+ running_workers_.erase(it);
+}
+
+void ServiceWorkerLifetimeTracker::AbortTiming(int64_t version_id) {
+ auto it = running_workers_.find(version_id);
+ // The entry may have been removed by AbortTiming.
+ if (it == running_workers_.end())
+ return;
+ running_workers_.erase(it);
+}
+
+void ServiceWorkerLifetimeTracker::RecordHistograms() {
+ base::TimeTicks now = tick_clock_->NowTicks();
+
+ for (auto& item : running_workers_) {
+ base::TimeDelta runtime = now - item.second;
+ if (runtime > kTimerDuration)
+ ServiceWorkerMetrics::RecordStillRunning(runtime);
+ }
+
+ if (running_workers_.empty())
+ timer_.Stop();
+}
+
+} // namespace content

Powered by Google App Engine
This is Rietveld 408576698