Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Side by Side Diff: content/browser/service_worker/service_worker_lifetime_tracker.cc

Issue 2706923003: Add UMA for how long service workers run for. (Closed)
Patch Set: constexpr Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "content/browser/service_worker/service_worker_lifetime_tracker.h"
6
7 #include "base/bind.h"
8 #include "base/time/default_tick_clock.h"
9 #include "content/browser/service_worker/service_worker_metrics.h"
10
11 namespace content {
12
13 constexpr base::TimeDelta kTimerDuration = base::TimeDelta::FromMinutes(5);
nhiroki 2017/02/23 07:54:23 Can you add a comment about why we chose 5 mins?
falken 2017/02/23 08:18:18 Good idea. Done.
14
15 ServiceWorkerLifetimeTracker::ServiceWorkerLifetimeTracker()
16 : ServiceWorkerLifetimeTracker(
17 base::WrapUnique(new base::DefaultTickClock)) {}
nhiroki 2017/02/23 07:54:23 base::MakeUnique<base::DefaultTickClock>()?
falken 2017/02/23 08:18:18 Done.
18
19 ServiceWorkerLifetimeTracker::ServiceWorkerLifetimeTracker(
20 std::unique_ptr<base::TickClock> tick_clock)
21 : tick_clock_(std::move(tick_clock)),
22 timer_(tick_clock_.get()),
23 weak_factory_(this) {}
24
25 ServiceWorkerLifetimeTracker::~ServiceWorkerLifetimeTracker() {}
nhiroki 2017/02/23 07:54:23 = default;
falken 2017/02/23 08:18:18 Done.
26
27 void ServiceWorkerLifetimeTracker::StartTiming(int64_t version_id) {
28 DCHECK(running_workers_.find(version_id) == running_workers_.end());
nhiroki 2017/02/23 07:54:23 DCHECK(!base::ContainsKey(running_workers_, versio
falken 2017/02/23 08:18:18 Done.
29
30 running_workers_[version_id] = tick_clock_->NowTicks();
31 if (!timer_.IsRunning()) {
32 timer_.Start(FROM_HERE, kTimerDuration,
33 base::Bind(&ServiceWorkerLifetimeTracker::RecordHistograms,
34 weak_factory_.GetWeakPtr()));
nhiroki 2017/02/23 07:54:23 I wonder if we don't have to make |this| weak beca
falken 2017/02/23 08:18:18 Ah I think you're right. Done.
35 }
36 }
37
38 void ServiceWorkerLifetimeTracker::StopTiming(int64_t version_id) {
39 auto it = running_workers_.find(version_id);
40 // The entry may have been removed by AbortTiming.
41 if (it == running_workers_.end())
42 return;
43 ServiceWorkerMetrics::RecordRuntime(tick_clock_->NowTicks() - it->second);
44 running_workers_.erase(it);
45 }
46
47 void ServiceWorkerLifetimeTracker::AbortTiming(int64_t version_id) {
48 auto it = running_workers_.find(version_id);
49 // The entry may have been removed by AbortTiming.
50 if (it == running_workers_.end())
51 return;
52 running_workers_.erase(it);
53 }
54
55 void ServiceWorkerLifetimeTracker::RecordHistograms() {
56 base::TimeTicks now = tick_clock_->NowTicks();
57
58 for (auto& item : running_workers_) {
59 base::TimeDelta runtime = now - item.second;
60 if (runtime > kTimerDuration)
61 ServiceWorkerMetrics::RecordStillRunning(runtime);
62 }
63
64 if (running_workers_.empty())
65 timer_.Stop();
66 }
67
68 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698