third_party/WebKit/LayoutTests/fast/dom/Window/orphaned-frame-access-expected.txt - Issue 2706923002: Rework security checks to be based on Window rather than Frame.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/Window/orphaned-frame-access-expected.txt

Issue 2706923002: Rework security checks to be based on Window rather than Frame. (Closed)

Patch Set: Meh Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 This tests access to a window with a null frame. You should see "PASS" for each of the three tests below.	1 This is a testharness.js-based test.

	2 PASS Named property access on detached Window

	3 FAIL Indexed property access on detached Window assert_equals: Indexed property should still be accessible. expected (string) "123" but got (undefined) undefine d
	dcheng 2017/05/15 06:15:32 I'm not really sure why, but this behavior seems t I'm not really sure why, but this behavior seems to have changed. I'll try to bisect it down, but for now, I'm going to check in a failing expectation (it seems to fail both with and without my patch) Yuki 2017/05/15 06:55:27 Probably, this is caused by the revert at https:// Show quoted text On 2017/05/15 06:15:32, dcheng (in AEST) wrote: > I'm not really sure why, but this behavior seems to have changed. I'll try to > bisect it down, but for now, I'm going to check in a failing expectation (it > seems to fail both with and without my patch) Probably, this is caused by the revert at https://codereview.chromium.org/2848503002/ I guess.
	4 PASS Interface Object access on detached Window

	5 Harness: the test ran to completion.

2	6

3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".

4

5

6 missing property: PASS

7 missing array index: PASS

8 missing interface object: PASS

9 PASS successfullyParsed is true

10

11 TEST COMPLETE

12

OLD	NEW