Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2706903002: Worker: Add comments about thread restriction to WorkerLoaderProxy (Closed)

Created:
3 years, 10 months ago by nhiroki
Modified:
3 years, 10 months ago
Reviewers:
yhirano
CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Add comments about thread restriction to WorkerLoaderProxy BUG=673711 Review-Url: https://codereview.chromium.org/2706903002 Cr-Commit-Position: refs/heads/master@{#451725} Committed: https://chromium.googlesource.com/chromium/src/+/8cfb8018660f8a412fed47d066f0d92913c3556c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M third_party/WebKit/Source/core/workers/WorkerLoaderProxy.h View 2 chunks +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerLoaderProxy.cpp View 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
nhiroki
PTAL, thanks!
3 years, 10 months ago (2017-02-21 05:25:18 UTC) #5
yhirano
lgtm
3 years, 10 months ago (2017-02-21 05:31:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706903002/20001
3 years, 10 months ago (2017-02-21 05:39:18 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/122876)
3 years, 10 months ago (2017-02-21 08:34:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706903002/20001
3 years, 10 months ago (2017-02-21 08:35:04 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 11:15:43 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8cfb8018660f8a412fed47d066f0...

Powered by Google App Engine
This is Rietveld 408576698