Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2814)

Unified Diff: net/quic/core/quic_framer.h

Issue 2706893002: Make QuicFramer unaware of path. Also, send/receive PathClose has no effect. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_connection_test.cc ('k') | net/quic/core/quic_framer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_framer.h
diff --git a/net/quic/core/quic_framer.h b/net/quic/core/quic_framer.h
index 1feb5b775f6bbaa41a7a0d4b42c45f815502834f..23d3c3ce6bae3a009d1f086f3562aca07cd87aeb 100644
--- a/net/quic/core/quic_framer.h
+++ b/net/quic/core/quic_framer.h
@@ -9,8 +9,6 @@
#include <cstdint>
#include <memory>
#include <string>
-#include <unordered_map>
-#include <unordered_set>
#include "base/macros.h"
#include "base/strings/string_piece.h"
@@ -332,9 +330,6 @@ class QUIC_EXPORT_PRIVATE QuicFramer {
Perspective perspective() const { return perspective_; }
- // Called when a PATH_CLOSED frame has been sent/received on |path_id|.
- void OnPathClosed(QuicPathId path_id);
-
QuicTag last_version_tag() { return last_version_tag_; }
private:
@@ -407,12 +402,6 @@ class QUIC_EXPORT_PRIVATE QuicFramer {
size_t buffer_length,
size_t* decrypted_length);
- // Checks if |path_id| is a viable path to receive packets on. Returns true
- // and sets |base_packet_number| to the packet number to calculate the
- // incoming packet number from if the path is not closed. Returns false
- // otherwise.
- bool IsValidPath(QuicPathId path_id, QuicPacketNumber* base_packet_number);
-
// Sets last_packet_number_. This can only be called after the packet is
// successfully decrypted.
void SetLastPacketNumber(const QuicPacketHeader& header);
@@ -491,20 +480,10 @@ class QUIC_EXPORT_PRIVATE QuicFramer {
std::string detailed_error_;
QuicFramerVisitorInterface* visitor_;
QuicErrorCode error_;
- // Set of closed paths. A path is considered as closed if a PATH_CLOSED frame
- // has been sent/received.
- // TODO(fayang): this set is never cleaned up. A possible improvement is to
- // use intervals.
- std::unordered_set<QuicPathId> closed_paths_;
// Updated by ProcessPacketHeader when it succeeds.
QuicPacketNumber last_packet_number_;
- // Map mapping path id to packet number of largest successfully decrypted
- // received packet.
- std::unordered_map<QuicPathId, QuicPacketNumber> largest_packet_numbers_;
// Updated by ProcessPacketHeader when it succeeds decrypting a larger packet.
QuicPacketNumber largest_packet_number_;
- // The path on which last successfully decrypted packet was received.
- QuicPathId last_path_id_;
// Updated by WritePacketHeader.
QuicConnectionId last_serialized_connection_id_;
// The last QUIC version tag received.
« no previous file with comments | « net/quic/core/quic_connection_test.cc ('k') | net/quic/core/quic_framer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698