Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Unified Diff: net/quic/core/quic_connection_test.cc

Issue 2706893002: Make QuicFramer unaware of path. Also, send/receive PathClose has no effect. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_connection.cc ('k') | net/quic/core/quic_framer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_connection_test.cc
diff --git a/net/quic/core/quic_connection_test.cc b/net/quic/core/quic_connection_test.cc
index 20ac251b74c0e6f4930b13e33a3d65dd32f4ec3e..c607cc267361866f88e057cf3eb4f8de57719692 100644
--- a/net/quic/core/quic_connection_test.cc
+++ b/net/quic/core/quic_connection_test.cc
@@ -4249,15 +4249,6 @@ TEST_P(QuicConnectionTest, Blocked) {
EXPECT_EQ(0u, connection_.GetStats().blocked_frames_sent);
}
-TEST_P(QuicConnectionTest, PathClose) {
- EXPECT_CALL(visitor_, OnSuccessfulVersionNegotiation(_));
-
- QuicPathCloseFrame path_close = QuicPathCloseFrame(1);
- ProcessPathClosePacket(&path_close);
- EXPECT_TRUE(QuicFramerPeer::IsPathClosed(
- QuicConnectionPeer::GetFramer(&connection_), 1));
-}
-
TEST_P(QuicConnectionTest, ZeroBytePacket) {
// Don't close the connection for zero byte packets.
EXPECT_CALL(visitor_, OnConnectionClosed(_, _, _)).Times(0);
@@ -4893,13 +4884,6 @@ TEST_P(QuicConnectionTest, EnableMultipathNegotiation) {
EXPECT_TRUE(QuicConnectionPeer::IsMultipathEnabled(&connection_));
}
-TEST_P(QuicConnectionTest, ClosePath) {
- QuicPathId kTestPathId = 1;
- connection_.SendPathClose(kTestPathId);
- EXPECT_TRUE(QuicFramerPeer::IsPathClosed(
- QuicConnectionPeer::GetFramer(&connection_), kTestPathId));
-}
-
TEST_P(QuicConnectionTest, OnPathDegrading) {
QuicByteCount packet_size;
const size_t kMinTimeoutsBeforePathDegrading = 2;
« no previous file with comments | « net/quic/core/quic_connection.cc ('k') | net/quic/core/quic_framer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698